Skip to content

Comments

Ignore update of downgrade compat action in dependabot#271

Merged
ranocha merged 2 commits intomainfrom
ignore-downgrade-dependabot
Dec 2, 2025
Merged

Ignore update of downgrade compat action in dependabot#271
ranocha merged 2 commits intomainfrom
ignore-downgrade-dependabot

Conversation

@JoshuaLampert
Copy link
Member

As discussed in #270 (comment). Is this what you had in mind, @ranocha?

@JoshuaLampert JoshuaLampert requested a review from ranocha December 2, 2025 11:02
@JoshuaLampert
Copy link
Member Author

Is there a better way to test this other than merging this PR and manually triggering dependabot after that to hope it does not create a new PR bumping the downgrade action?

@github-actions
Copy link
Contributor

github-actions bot commented Dec 2, 2025

Benchmark Results (Julia v1.10)

Time benchmarks
main 78ee350... main / 78ee350...
bbm_1d/bbm_1d_basic.jl - rhs!: 13.8 ± 0.3 μs 13.7 ± 0.3 μs 1.01 ± 0.031
bbm_1d/bbm_1d_fourier.jl - rhs!: 0.217 ± 0.011 ms 0.535 ± 0.0097 ms 0.405 ± 0.022
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 0.0821 ± 0.0012 ms 0.0826 ± 0.00097 ms 0.994 ± 0.019
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 0.0348 ± 0.001 ms 0.0349 ± 0.00085 ms 0.996 ± 0.038
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 27.4 ± 0.45 μs 27.1 ± 0.39 μs 1.01 ± 0.022
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 0.0488 ± 0.00052 ms 0.0487 ± 0.00061 ms 1 ± 0.016
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 4.8 ± 0.67 μs 4.48 ± 0.25 μs 1.07 ± 0.16
kdv_1d/kdv_1d_basic.jl - rhs!: 1.7 ± 0.03 μs 1.62 ± 0.14 μs 1.05 ± 0.092
kdv_1d/kdv_1d_implicit.jl - rhs!: 1.69 ± 0.021 μs 1.58 ± 0.17 μs 1.07 ± 0.12
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.2 ± 0.0089 ms 0.2 ± 0.0089 ms 1 ± 0.063
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.146 ± 0.0043 ms 0.15 ± 0.0053 ms 0.978 ± 0.045
time_to_load 1.96 ± 0.0023 s 1.95 ± 0.014 s 1.01 ± 0.0073
Memory benchmarks
main 78ee350... main / 78ee350...
bbm_1d/bbm_1d_basic.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_1d/bbm_1d_fourier.jl - rhs!: 1 allocs: 4.12 kB 1 allocs: 4.12 kB 1
bbm_bbm_1d/bbm_bbm_1d_basic_reflecting.jl - rhs!: 5 allocs: 1.17 kB 5 allocs: 1.17 kB 1
bbm_bbm_1d/bbm_bbm_1d_dg.jl - rhs!: 10 allocs: 8.62 kB 10 allocs: 8.62 kB 1
bbm_bbm_1d/bbm_bbm_1d_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
bbm_bbm_1d/bbm_bbm_1d_upwind_relaxation.jl - rhs!: 2 allocs: 8.25 kB 2 allocs: 8.25 kB 1
hyperbolic_serre_green_naghdi_1d/hyperbolic_serre_green_naghdi_dingemans.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_basic.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
kdv_1d/kdv_1d_implicit.jl - rhs!: 0 allocs: 0 B 0 allocs: 0 B
serre_green_naghdi_1d/serre_green_naghdi_well_balanced.jl - rhs!: 0.075 k allocs: 0.66 MB 0.075 k allocs: 0.66 MB 1
svaerd_kalisch_1d/svaerd_kalisch_1d_dingemans_relaxation.jl - rhs!: 0.042 k allocs: 0.315 MB 0.042 k allocs: 0.315 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 19856305351

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.467%

Totals Coverage Status
Change from base Build 19856265829: 0.0%
Covered Lines: 2313
Relevant Lines: 2349

💛 - Coveralls

Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, thanks!

@ranocha ranocha merged commit 9c32f02 into main Dec 2, 2025
13 checks passed
@ranocha ranocha deleted the ignore-downgrade-dependabot branch December 2, 2025 11:50
@ranocha
Copy link
Member

ranocha commented Dec 2, 2025

Is there a better way to test this other than merging this PR and manually triggering dependabot after that to hope it does not create a new PR bumping the downgrade action?

I do not know any...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants