Conversation
jeremyfiel
left a comment
jeremyfiel
left a comment
There was a problem hiding this comment.
If the spec remains unchanged, couple things can be updated in this schema version
| - xpath | ||
| default: simple | ||
| - $ref: '#/$defs/criterion-expression-type-object' | ||
| type: string |
There was a problem hiding this comment.
unnecessary because the enums are only strings
| type: string |
| type: | ||
| description: The type of condition to be applied | ||
| default: simple | ||
| oneOf: |
|
@markus-96 thanks for the PR. Would you be able to take a look at the feedback from @jeremyfiel? Also, can you target |
|
@markus-96 appreciate your patience here. I was holding off on approving during to pending infra changes. Those infra changes are not merged, and we've changed the schema directory locations to align with the OpenAPI Specification repos. Would you be able to update your PR to make the changes against the new schema locations, and also take a look at @jeremyfiel comments above? |
|
@markus-96 gentle reminder here. Would you be able to update your PR to make the changes against the new schema locations, and also take a look at @jeremyfiel comments above? |
3 participants
see #336
this is my first PR to this project, so I am happy if you tell me if it meets your expectations :)
If needed, I can also try to take part in the meeting coming in two weeks.
reading #337 (comment) ("Need to digest #336 before discussing"), maybe this helps:
I would consider the following class diagram for modelling a Criterion Object: