Skip to content

Conversation

@ralfhandl
Copy link
Contributor

Explicitly state that zero target nodes is a no-op.

Rephrase text to also cover two or more target nodes.

@ralfhandl ralfhandl requested a review from a team as a code owner November 5, 2025 08:32
@mikekistler
Copy link
Contributor

The description says:

Explicitly state that zero target nodes is a no-op.

But I don't see this in the updated text. Did I miss it?

@ralfhandl
Copy link
Contributor Author

It's right after the table in https://github.com/ralfhandl/Overlay-Specification/blob/2ff2da9034659fbf14a5b03a49a63f77b5e4187c/versions/1.1.0-dev.md?plain=1#L123

If the target JSONPath expression selects zero nodes, the action succeeds without changing the target document.

@ralfhandl ralfhandl requested a review from mikekistler November 6, 2025 08:03
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

@ralfhandl I love your overlay-experiments repo! This is awesome!

@ralfhandl ralfhandl merged commit 7877e79 into OAI:main Nov 6, 2025
3 checks passed
@ralfhandl ralfhandl deleted the zero-targets branch November 6, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants