Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/v3.1/tictactoe fix security property name #116

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

notEthan
Copy link
Contributor

Unless I'm misunderstanding it, this corrects the property name inside this security object to correctly correspond to a key of /components/securitySchemas, which it did not previously.

Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @notEthan,

Thanks for finding this!

Could you please change the YAML file instead of the JSON file?

The JSON file will be regenerated from the YAML file, which would wipe your changes.

Thanks in advance!

@notEthan
Copy link
Contributor Author

Updated with the yaml file

@ralfhandl ralfhandl requested review from a team December 2, 2024 12:23
@ralfhandl
Copy link
Contributor

ralfhandl commented Dec 2, 2024

Blocked by

@lornajane lornajane merged commit 9b4a052 into OAI:main Dec 19, 2024
1 check failed
@notEthan notEthan deleted the tictactoe-security branch February 8, 2025 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants