Code refactoring with bug fixing #6
Open
+150
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug: --autobreak flag provide the injection of "int 3" instruction into the shellcode, what could corrupt the shellcode execution. Solution: set the breakpoint before the jump to shellcode execution. Bug: --nopause flag doesn't work for x64bit program. Solution: add the check of --nopause flag for x64bit program. Code refactoring: - code is bit version independent - avoided program crashes on shell code execution - avoided memory leaks - code was refactored
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: --autobreak flag provide the injection of "int 3" instruction into the shellcode, what could corrupt the shellcode execution.
Solution: set the breakpoint before the jump to shellcode execution.
Bug: --nopause flag doesn't work for x64bit program.
Solution: add the check of --nopause flag for x64bit program.
Code refactoring: