Dockerfile with OBO Dashboard and its requirements #157
Conversation
📝 Walkthrough""" WalkthroughA new Dockerfile is introduced that builds an image based on Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant odk.sh
participant Docker
participant obo-dashboard (Container)
User->>odk.sh: Execute script
odk.sh->>Docker: Run anitacaron/obo-dashboard image (single config volume)
Docker->>obo-dashboard (Container): Start container with /tools as working directory
obo-dashboard (Container)-->>User: Executes dashboard logic
""" 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (4)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (1)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (3)
Dockerfile (2)
1-4: Pin the base image to a specific version for reproducibility.Using
obolibrary/robot:latestmay introduce breaking changes when the image is updated. Pin to a known working tag (e.g.,obolibrary/robot:1.7.0) to ensure consistent builds.
6-13: Minimize image size by disabling recommended packages.Add
--no-install-recommendsto theapt-get installcommand to avoid pulling in unnecessary packages, and consider combining clean-up steps:-RUN apt-get update && \ - apt-get install -y git \ +RUN apt-get update && \ + apt-get install -y --no-install-recommends git \ python3 \ python3-pip \ python3-venv \ python-is-python3 \ jq && \ rm -rf /var/lib/apt/lists/*odk.sh (1)
12-17: Remove obsolete commented-out invocation.The block for
obolibrary/odkfullis no longer needed and adds noise. Delete these lines to keep the script concise.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
Dockerfile(1 hunks)odk.sh(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: QC
🔇 Additional comments (1)
odk.sh (1)
19-22: Verify that omitting volume mounts fits your workflow.With no mounts, changes to host files won’t reflect in the container at runtime. Ensure that baking the code and configuration into the image meets your development and deployment needs.
Copy only requirements.txt before installing to avoid reinstalling dependencies on every source change Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
…allation; modify odk.sh to include dashboard config volume
The aim with the Dockerfile is to easily update OBO Dashboard in different repositories (NOR, dashboard template and the OBO Dashboard itself) and not to be dependent on the ODK docker build.
Summary by CodeRabbit