Update upheno.md #2648
Merged
Update upheno.md #2648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matentzn
approved these changes
Nov 5, 2024
nlharris
approved these changes
Nov 5, 2024
Contributor
nlharris
left a comment
nlharris
left a comment
There was a problem hiding this comment.
This looks good to me (thanks for fixing a few typos and adding a publication, as well as switching the contact person).
As a best practice, I recommend putting something in the commit message about what you're changing.
deepakunni3
approved these changes
Nov 6, 2024
Member
deepakunni3
left a comment
deepakunni3
left a comment
There was a problem hiding this comment.
@jamesamcl I took the liberty of quoting the title for publication on line 37: jamesamcl@752a591#diff-c0c6a42b3c26feecc1bedcf274e6ff30b504a11b456c8676ae9fb7b5bca5f830L37
The lack of quotes was causing issues with the YAML parser.
Contributor
|
Awesome thanks @jamesamcl and @deepakunni3! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @matentzn