Skip to content

[19.0][MIG] hr_timesheet#5732

Merged
pedrobaeza merged 1 commit into
OCA:19.0from
hbrunn:19.0-hr_timesheet
Jun 17, 2026
Merged

[19.0][MIG] hr_timesheet#5732
pedrobaeza merged 1 commit into
OCA:19.0from
hbrunn:19.0-hr_timesheet

Conversation

@hbrunn

@hbrunn hbrunn commented Jun 16, 2026

Copy link
Copy Markdown
Member

No description provided.

@hbrunn hbrunn added this to the 19.0 milestone Jun 16, 2026
@hbrunn

hbrunn commented Jun 16, 2026

Copy link
Copy Markdown
Member Author

/ocabot migration hr_timesheet

@carlos-lopez-tecnativa carlos-lopez-tecnativa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just a technical note: in this commit, Odoo removed default_user in favor of default_user_group:
odoo/odoo@6451f5c#diff-b221f962f9047cb9f77630022f0d5689469db17e677854bc38f2653837791d75R9

In a fresh v19 database created without demo data, this new group does not have any privileges assigned.

Image

However, in a database migrated from v18 (also without demo data), I can see that this group does have the privileges assigned.

Image

I'm not sure whether each module should handle this individually or if it is acceptable for the base migration script to copy all groups from default_user to default_user_group, considering that Odoo only performs this assignment when demo data is installed:

TT58641

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

About the default groups for new users, I think it can be done in base module, yes.

@pedrobaeza pedrobaeza merged commit 558263f into OCA:19.0 Jun 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants