Skip to content

[ADD][16.0] add account_ecotax_report #456

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mourad-ehm wants to merge 2 commits into
base: 16.0
Choose a base branch
from
Open

[ADD][16.0] add account_ecotax_report #456

mourad-ehm wants to merge 2 commits into from

Conversation

@mourad-ehm
Copy link
Contributor

@mourad-ehm mourad-ehm commented Nov 28, 2024

This module adds reporting fields to the eco-tax line object and
the menu to acces tree & pivot view to facilitate the eco-tax declaration.

Abraao-Levasseur
Abraao-Levasseur reviewed Dec 11, 2024
View reviewed changes
Copy link

@Abraao-Levasseur Abraao-Levasseur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works fine after settings defined as described here : #454 (review)
image

@florian-dacosta
Copy link
Contributor

florian-dacosta commented Feb 7, 2025

@mourad-ehm Can you remove the test-requirement and rebase this one ?

@mourad-ehm mourad-ehm force-pushed the 16-Add_account_ecotax_report branch from d31c944 to fdbb5fa Compare February 13, 2025 09:32
@florian-dacosta florian-dacosta mentioned this pull request Mar 14, 2025
Merged
@florian-dacosta florian-dacosta force-pushed the 16-Add_account_ecotax_report branch from 2c38ea8 to 21c9277 Compare March 14, 2025 11:15
@mourad-ehm
Copy link
Contributor Author

mourad-ehm commented Mar 17, 2025

Thanks @florian-dacosta for the improvement

florian-dacosta
florian-dacosta approved these changes Mar 19, 2025
View reviewed changes
Copy link
Contributor

@florian-dacosta florian-dacosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test + code review LGTM

@florian-dacosta
Copy link
Contributor

florian-dacosta commented Mar 19, 2025

@Abraao-Levasseur Since you seem to have tested it with sucess, do you think you saw enough to approve it ?

@bealdav bealdav force-pushed the 16-Add_account_ecotax_report branch from 21c9277 to 6147cf9 Compare June 27, 2025 11:13
@florian-dacosta florian-dacosta force-pushed the 16-Add_account_ecotax_report branch 3 times, most recently from e24689e to 22c28ad Compare August 1, 2025 13:57
@florian-dacosta florian-dacosta force-pushed the 16-Add_account_ecotax_report branch from 22c28ad to f415c49 Compare August 1, 2025 13:58
@OCA-git-bot
Copy link
Contributor

OCA-git-bot commented Aug 1, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

4 more reviewers

@Abraao-Levasseur Abraao-Levasseur Abraao-Levasseur left review comments

@bealdav bealdav bealdav approved these changes

@florian-dacosta florian-dacosta florian-dacosta approved these changes

@hparfr hparfr hparfr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mourad-ehm @florian-dacosta @OCA-git-bot @bealdav @hparfr @Abraao-Levasseur