[17.0][ADD] account_invoice_currency_by_partner: New module

[eduezerouali-tecnativa]

cc @Tecnativa TT59474

New module that lets you set a default currency on a partner, which is then automatically applied to vendor bills.

ping @sergio-teruel @pedrobaeza

[pedrobaeza]

Suggested change

	help="This field set currency_id in vendor bill automatically",
	help="If field, this value is set as currency in vendor bills for this partner",

[victoralmau]

Code review OK

[eduezerouali-tecnativa]

I made improvements, and now its working with customer invoice too. Also add some test.
ping @victoralmau @pedrobaeza @sergio-teruel

[pedrobaeza]

Please check independently if each field is filled, or you may assign an empty value.

[sergio-teruel]

don't use the same label for both fields...

[eduezerouali-tecnativa]

done, anyways open to suggestions for the label.

[eduezerouali-tecnativa]

@pedrobaeza did add another condition before assigning the value.

[pedrobaeza]

Watch out! You shouldn't put a dependency that affects previous records. Imagine all the past invoices being changed because you now change the currency in the partner...

Suggested change

	@api.depends("partner_id.vendor_currency_id", "partner_id.customer_currency_id")
	@api.depends("partner_id")

[eduezerouali-tecnativa]

change done.

[pedrobaeza]

Why not depending on AccountInvoicingCommon for avoiding most of the stuff and be sure the CoA is loaded?

[eduezerouali-tecnativa]

Good point, did not know much about AccountTestInvoicingCommon, but after a quick research this will make sure account.move works correctly.

[luisDIXMIT]

I have this setting:

But when I create a vendor bill for that partner, the GBP currency is used.

On the other hand, I created a purchase order and the currency was USD, which was expected. But then I created an invoice from that purchase order and the currency was still USD, even though I’ve set GBP for vendor bills. Maybe this is the expected behaviour to maintain consistency between the purchase order and the invoice. Let me know.

[eduezerouali-tecnativa]

@luisDIXMIT I have checked, and when you create a vendor bill for that partner, EUR is used. Am I missing something?
We did not intend to change anything in the purchase workflow, but in any case, there is a supplier currency field that actually manages this.

[luisDIXMIT]

@luisDIXMIT I have checked, and when you create a vendor bill for that partner, EUR is used. Am I missing something? We did not intend to change anything in the purchase workflow, but in any case, there is a supplier currency field that actually manages this.

Yes, you're right. I’ve now run the same test and it works. However, when I tested with a customer invoice, the currency wasn’t updated, and I even got this error when saving the invoice. The pricelist currency is USD, and the invoice shows USD as well (maybe the correct GBP currency is being used in the background? I’m not sure). Anyway, I don’t intend to block this PR.