-
-
Notifications
You must be signed in to change notification settings - Fork 770
[17.0][MIG] account_invoice_tax_required: Migration to 17.0 #2182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
hildickethan
wants to merge
74
commits into
OCA:17.0
Choose a base branch
from
hildickethan:17.0-mig-account_invoice_tax_required
base: 17.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[17.0][MIG] account_invoice_tax_required: Migration to 17.0 #2182
hildickethan
wants to merge
74
commits into
OCA:17.0
from
hildickethan:17.0-mig-account_invoice_tax_required
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_tax_required/es/
Currently translated at 100,0% (4 of 4 strings) Translation: account-invoicing-11.0/account-invoicing-11.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-11-0/account-invoicing-11-0-account_invoice_tax_required/de/
Using `invoice_validate` method for validating invoice, makes the call to the sequence to be done before, and although rollbacking the transaction, the next number is already assigned and then you may have gaps in your numbering. Thus, we do the check before this, on the first executed method.
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-12.0/account-invoicing-12.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_invoice_tax_required/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/de/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/hr/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/es/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/pt_BR/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/
Currently translated at 100.0% (3 of 3 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/de/
- Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.
…validation If you use the action in the invoice list for doing mass validation, the restriction about taxes required is bypassed. That's because the mass validation wizard is not calling `action_post`, but directly `_post`. TT47059
…blem If doing mass validation, and a missing tax error appears, you don't know on which invoice is the problem, so let's improve the message for indicating it. PO files + translations have been adapted as well for smoother transition and avoid extra work by the translators. TT47059
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/
… tax The customer is included in the error message of the line containing a product without tax and an action is added to go directly to the list of invoices containing those lines. In addition, the method call is changed so that it receives and checks all the invoices instead of doing it one at a time. TT47521
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/
Currently translated at 100.0% (5 of 5 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/it/
Currently translated at 100.0% (5 of 5 strings) Translation: account-invoicing-16.0/account-invoicing-16.0-account_invoice_tax_required Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-16-0/account-invoicing-16-0-account_invoice_tax_required/sv/
7f55a21 to
a483c43
Compare
a483c43 to
4aa494c
Compare
luisDIXMIT
approved these changes
Dec 4, 2025
Contributor
luisDIXMIT
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on runboat, LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 17.0, based on the 16.0 version