[18.0][MIG] account_warn_option: Migration to 18.0 #2194
+827
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sabrinaRMartin
force-pushed
the
18.0-mig-account_warn_option
branch
2 times, most recently
from
45f8542 to
7fd0b40
Compare
sabrinaRMartin
force-pushed
the
18.0-mig-account_warn_option
branch
from
4258f4e to
7394b8c
Compare
Contributor
|
What was the reason for the latest commit? |
Andrii9090
approved these changes
Jan 5, 2026
Contributor
Add the temporal referece to this PR OCA/server-ux#1204 to be able to test this module |
Shide
approved these changes
Jan 7, 2026
Contributor
Shide
left a comment
Shide
left a comment
There was a problem hiding this comment.
Code and functional review
Shide
reviewed
Jan 7, 2026
| <xpath expr="//field[@name='invoice_warn_msg']" position="before"> | ||
| <field | ||
| name="invoice_warn_option" | ||
| domain="[('allowed_warning_type', '=', invoice_warn), ('allowed_warning_usage', 'in', ('all', 'partner_invoice_warn'))]" |
Contributor
There was a problem hiding this comment.
I think base_warn_options submodules (including this one), could improve this domain to allow allowed_warning_type == False to be shown on warnings and block.
This is an improvement, and if it's done, should be done in a separate commit with help strings improvements.
Something like this:
Suggested change
| domain="[('allowed_warning_type', '=', invoice_warn), ('allowed_warning_usage', 'in', ('all', 'partner_invoice_warn'))]" | |
| domain="['|', ('allowed_warning_type', '=', invoice_warn), ('allowed_warning_type', '=', False), ('allowed_warning_usage', 'in', ('all', 'partner_invoice_warn'))]" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration from version 15.0 to version 18.0
This module depends on PR:
@moduon @Shide MT-13043
https://www.loom.com/share/43b2355ab5d5474ea810a422feb513a3