[16.0][FIX] account_billing: fix issue when create billings from refunds

[AungKoKoLin1997]

This PR fixes an issue that occurs when creating billings from the list view of credit notes, or when creating credit notes and invoices together by calling _create_billing from dependency modules or test cases.

@qrtl QT6260

[OCA-git-bot]

Hi @Saran440,
some modules you are maintaining are being modified, check this out!

[yostashiro]

Code review. LGTM. 👍

[Saran440]

LGTM 👍

In my opinion, should we add a new method so other modules can hook into it?

{
    "partner_id": partner.id,
    "bill_type": self._get_billing_type(),
    "billing_line_ids": [
        Command.create(
            {
                "move_id": m.id,
                "amount_total": m.amount_total * (-1 if m.move_type in ["out_refund", "in_refund"] else 1),
                "amount_residual": m.amount_residual * (-1 if m.move_type in ["out_refund", "in_refund"] else 1),
            }
        )
        for m in self
     ],
}

[AungKoKoLin1997]

In my opinion, should we add a new method so other modules can hook into it?

@Saran440 I think it is better to have a method _prepare_billing_vals() instead of def _create_billing(): and do the creation inside def action_create_billing(): by calling _prepare_billing_vals().
How do you think?

[Saran440]

I agree with you 👍

[AungKoKoLin1997]

@yostashiro @Saran440 I added the new commit to follow up on my above comment.
#2195 (comment)

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[nobuQuartile]

LGTM
Functional review

[yostashiro]

LGTM.

[etobella]

LGTM

[etobella]

/ocabot merge minor

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-2195-by-etobella-bump-minor, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at f546245. Thanks a lot for contributing to OCA. ❤️