Skip to content

[FIX] sale_stock_picking_invoicing: Narration could be false #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
OCA-git-bot merged 1 commit into from
Dec 30, 2025
+3 −1
Merged

[FIX] sale_stock_picking_invoicing: Narration could be false #2203

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions sale_stock_picking_invoicing/tests/test_sale_stock.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,7 @@ def test_picking_invoicing_partner_shipping_invoiced(self):
sale_order_2 = self.env.ref(
"sale_stock_picking_invoicing.main_company-sale_order_2"
)
sale_order_2.note = False
sale_order_2.action_confirm()
picking2 = sale_order_2.picking_ids
self.picking_move_state(picking2)
Expand Down
3 changes: 2 additions & 1 deletion sale_stock_picking_invoicing/wizards/stock_invoice_onshipping.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ def _build_invoice_values_from_pickings(self, pickings):
# origins.add(sale_values["invoice_origin"])
payment_refs.add(sale_values["payment_reference"])
refs.add(sale_values["ref"])
narration.add(sale_values["narration"])
if sale_values["narration"]:
narration.add(sale_values["narration"])

sale_values_rm = {
k: sale_values[k]
Expand Down