Skip to content

[18.0][IMP] account_payment_term_extension: extract payment days logic to a…#838

Open
MarinaAForgeFlow wants to merge 1 commit intoOCA:18.0from
ForgeFlow:18.0-imp-account_payment_term_extension-extract_payment_days_logic
Open

[18.0][IMP] account_payment_term_extension: extract payment days logic to a…#838
MarinaAForgeFlow wants to merge 1 commit intoOCA:18.0from
ForgeFlow:18.0-imp-account_payment_term_extension-extract_payment_days_logic

Conversation

@MarinaAForgeFlow
Copy link
Copy Markdown

@MarinaAForgeFlow MarinaAForgeFlow commented Jun 2, 2025 •
edited
Loading

… new method

Extract the payment days logic to a new method so that the logic can be easily inherited or modified.

@MarinaAForgeFlow MarinaAForgeFlow mentioned this pull request Jun 2, 2025
Open
@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 5, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 5, 2025
@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Oct 26, 2025
@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 18.0-imp-account_payment_term_extension-extract_payment_days_logic branch from 9c54a1a to 56cda44 Compare November 4, 2025 09:11
ofonseca-pyming
ofonseca-pyming approved these changes Nov 6, 2025
View reviewed changes
Copy link
Copy Markdown

@ofonseca-pyming ofonseca-pyming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
easier to unit-test and more readable

edescalona
edescalona approved these changes Nov 14, 2025
View reviewed changes
Copy link
Copy Markdown

@edescalona edescalona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@edescalona edescalona mentioned this pull request Nov 14, 2025
Merged
@edescalona
Copy link
Copy Markdown

edescalona commented Nov 14, 2025

Hi @MarinaAForgeFlow, could you improve the test pass rate? Thanks

@MarinaAForgeFlow
[IMP] account_payment_term_extension: extract payment days logic to a…
ce2fee3 
… new method

Extract the paument days applicaton logic to a new method so that the logic can be easily inherited or modified
@MarinaAForgeFlow MarinaAForgeFlow force-pushed the 18.0-imp-account_payment_term_extension-extract_payment_days_logic branch from 56cda44 to ce2fee3 Compare December 4, 2025 19:16
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 6, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

1 similar comment
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Dec 6, 2025

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 5, 2026

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@ofonseca-pyming ofonseca-pyming ofonseca-pyming approved these changes

@edescalona edescalona edescalona approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MarinaAForgeFlow @edescalona @OCA-git-bot @ofonseca-pyming