[ADD] account_payment_return_revoke_ mandate#856
Conversation
glitchov
force-pushed
the
18.0-mig-account_payment_return_revoke_mandate-hda
branch
2 times, most recently
from
1160678 to
19e6f76
Compare
| [build-system] | ||
| requires = ["whool"] | ||
| build-backend = "whool.buildapi" |
There was a problem hiding this comment.
why is this necessary? what does it do?
There was a problem hiding this comment.
pyproject.toml is added to all addons usually by the pre-commit task.
It is used to package the odoo addons. More on this here: https://github.com/sbidoul/whool
|
#833 was merged. Please rebase and remove the "DON'T MERGE" commit. |
| @@ -0,0 +1 @@ | |||
| - Quentin Groulard \<quentin.groulard@acsone.eu\> | |||
There was a problem hiding this comment.
@glitchov You might want to add yourself to the contributors list 😉
yvaucher
left a comment
yvaucher
left a comment
There was a problem hiding this comment.
LGTM
Don't forget to add yourself as a contributor.
glitchov
force-pushed
the
18.0-mig-account_payment_return_revoke_mandate-hda
branch
from
19e6f76 to
6621abb
Compare
| def _payment_returned(self, return_line): | ||
| # make override easier | ||
| self._revoke_mandate(return_line) |
There was a problem hiding this comment.
I think this hook is still useful in the base module (account_payment_return), can't we migrate #310 as well instead of merging everything in account_payment_return_revoke_mandate ?
glitchov
force-pushed
the
18.0-mig-account_payment_return_revoke_mandate-hda
branch
3 times, most recently
from
ac46085 to
3add1b0
Compare
There was a problem hiding this comment.
Could you please explain why we need this file ? Is it still needed now that you are based on #879 ?
glitchov
force-pushed
the
18.0-mig-account_payment_return_revoke_mandate-hda
branch
from
3add1b0 to
0fca0aa
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
6 participants
Adds a flag on payment return reason to automatically revoke mandate in the corresponding invoice.
It's a migration of the never merged pull request #312