[19.0][MIG] account_payment_term_extension: Migration to 19.0 by pablo-cort-s73 · Pull Request #903 · OCA/account-payment

pablo-cort-s73 · 2025-11-11T16:23:54Z

The module version was updated to 19.0.1.0.0 in the manifest.
In the account_payment_term_holiday model, the check_holiday constraint was refactored to use the new odoo.fields.Domain API and marked as @api.private.
Tests were modified to create the necessary data programmatically instead of relying on external data records, following new best practices.

…_term_extension Add support for months and weeks in account.payment.term.line Add unittest PEP8 validation

Fix and add a feature for apply a chronological order on lines Merge of the 'account_payment_term_multi_day' module Add icon to module

[UPD] Update account_payment_term_extension.pot

Closes OCA#527

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/es/

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/pt_BR/

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/fr/

Currently translated at 100.0% (28 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/fr_CH/

Currently translated at 85.7% (24 of 28 strings) Translation: account-invoicing-12.0/account-invoicing-12.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-invoicing-12-0/account-invoicing-12-0-account_payment_term_extension/hr/

…s precision_digits

Currently translated at 100.0% (28 of 28 strings) Translation: account-payment-13.0/account-payment-13.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-payment-13-0/account-payment-13-0-account_payment_term_extension/es_AR/

…ion in payment term lines

…re resilient * A `account.journal` record was being searched and used to create invoices, even though it was not necessary. This introduced the problem of finding more than one record that satisfied the search query, breaking the test for a singleton error. This removes the need for that. * Extract a method for creating the invoice. * Don't depend on variable year for tests. TT27288 Co-Authored-By: Pedro M. Baeza <pedro.baeza@tecnativa.com>

* Standard procedure * Adapt code * Adapt tests * Convert tests to SavepointCase [UPD] Update account_payment_term_extension.pot

…F part

…and weeks fix computing months and weeks

reformat

add test months

black

Currently translated at 100.0% (34 of 34 strings) Translation: account-payment-14.0/account-payment-14.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-payment-14-0/account-payment-14-0-account_payment_term_extension/es_AR/

Currently translated at 100.0% (44 of 44 strings) Translation: account-payment-18.0/account-payment-18.0-account_payment_term_extension Translate-URL: https://translation.odoo-community.org/projects/account-payment-18-0/account-payment-18-0-account_payment_term_extension/tr/

Reyes4711-S73

LGTM
Funcional review ok

arantxa-s73

LGTM

Reyes4711-S73 · 2025-11-12T08:42:07Z

@OCA/banking-maintainers Please, can you merge this PR?

StefanRijnhart · 2025-11-12T08:56:02Z

@Reyes4711-S73 Please read up on the section 'Get your code merged' of https://odoo-community.org/resources/code. On top of that, the various S73 reviews can be considered team service and do not automatically qualify a PR for merging. Also, please make a little less noise.

Reyes4711-S73 · 2025-11-12T12:24:23Z

@StefanRijnhart Sorry if I'm making "noise" in newer PR like this. In other PR that I have been reviewing, I requested a maintainer review/merge are PR that we have it opened more time, some even more than 2 years

OCA-git-bot · 2025-11-18T04:40:02Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

etobella · 2025-11-27T05:27:16Z

account_payment_term_extension/readme/CREDITS.md

@@ -1,2 +1,2 @@
-The migration of this module from 17.0 to 18.0 was financially supported
-by THERA S.R.L.
+The migration of this module from 18.0 to 19.0 was financially supported


You shouldn't remove previous comments, the credits of THERA should remain

Not really, Enric. Past comments of credits should be removed.

And this is logical, as funding one version migration doesn't grant you infinite advertising for life.

Ok @etobella , but according to the migration guide, references in other versions must be removed. @pedrobaeza , can you confirm the correct way to do this?

https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0#:~:text=Remove%20references%20in%20CREDITS.rst%20of%20past%20financed%20migrations%20by%20other%20companies

pedrobaeza · 2025-11-27T07:14:31Z

/ocabot migration account_payment_term_extension

odooNextev · 2026-01-16T13:25:01Z

Hi @pablo-cort-s73,
we opened an issue for a major issue in v18.0 that appears to be impacting this migration as well: #919
I created a PR to solve it and it's close to merge: #920

pablo-cort-s73 · 2026-01-19T07:31:50Z

Of course @odooNextev right now I add the commit to the migration. Thanks a lot

…st and fix tests

Borruso

LGTM

pablo-cort-s73 · 2026-02-23T07:15:47Z

@odooNextev fix commit added before migration commit. Can you check it, pls?

odooNextev · 2026-02-23T10:41:39Z

@odooNextev fix commit added before migration commit. Can you check it, pls?

Code looks good, but I cannot try it on runboat cause it doesn't work.

pablo-cort-s73 · 2026-02-23T16:19:42Z

@odooNextev fix commit added before migration commit. Can you check it, pls?

Code looks good, but I cannot try it on runboat cause it doesn't work.

@odooNextev Runboat on. 👍

odooNextev

LGTM
Issue solved: #919

Alexis de Lattre and others added 30 commits November 11, 2025 15:27

Port module payment_term_rounding to v8 and rename to account_payment…

ab793f4

…_term_extension Add support for months and weeks in account.payment.term.line Add unittest PEP8 validation

Migration V9 account_payment_term_extension

0635abb

Fix and add a feature for apply a chronological order on lines Merge of the 'account_payment_term_multi_day' module Add icon to module

[IMP] account_payment_term_extension: Switch company

4eb1a03

Port account_payment_term_extension to v10

db17b8c

[UPD] Module account_payment_term_extension, added holidays management

98e2d5a

[MIG] account_payment_term_extension: Migration to 11.0

4a84d05

[MIG] account_payment_term_extension: Migration to 12.0

7c10175

[UPD] Update account_payment_term_extension.pot

[FIX] account_payment_term_extension: Add payment_days to view

bb85d93

Closes OCA#527

12.0 [FIX] the sequential line was not visible

2c811df

[IMP] account_payment_term_extension: black, isort, prettier

0bfeb5f

[MIG] account_payment_term_extension: Migration to 13.0

b5cf7f3

[FIX] account_payment_term_extension: bad use of precision_rounding v…

4a3f0bb

…s precision_digits

[IMP] account_payment_term_extension: Add amount_untaxed to value opt…

7804f80

…ion in payment term lines

[IMP] account_payment_term_extension: black, isort, prettier

f0fbc7e

[MIG+IMP] account_payment_term_extension: Migration to 14.0

7fc9b3a

* Standard procedure * Adapt code * Adapt tests * Convert tests to SavepointCase [UPD] Update account_payment_term_extension.pot

[FIX] account_payment_term_extension missing standard option into ELI…

323c8a0

…F part

[ADD][14.0] account_payment_term_discount

a6fc8be

[14.0] [account_payment_term_extension] [FIX] error computing months …

a09bb8a

…and weeks fix computing months and weeks

reformat

6ca8628

reformat

test months

50f3cb9

add test months

black

9a51f43

black

Added translation using Weblate (French (France))

178b237

pablo-cort-s73 mentioned this pull request Nov 11, 2025

Migration to version 19.0 #885

Open

14 tasks

Reyes4711-S73 approved these changes Nov 11, 2025

View reviewed changes

arantxa-s73 approved these changes Nov 12, 2025

View reviewed changes

OCA-git-bot added the approved label Nov 12, 2025

pablo-cort-s73 force-pushed the 19.0-mig-account_payment_term_extension branch from 5c163af to 8bdf37f Compare November 13, 2025 14:40

OCA-git-bot added the ready to merge label Nov 18, 2025

etobella requested changes Nov 27, 2025

View reviewed changes

OCA-git-bot removed approved ready to merge labels Nov 27, 2025

pablo-cort-s73 force-pushed the 19.0-mig-account_payment_term_extension branch from 8bdf37f to 08c7679 Compare November 27, 2025 07:09

OCA-git-bot added this to the 19.0 milestone Nov 27, 2025

pablo-cort-s73 requested a review from etobella November 28, 2025 06:54

pablo-cort-s73 force-pushed the 19.0-mig-account_payment_term_extension branch from 08c7679 to 17e6b27 Compare November 28, 2025 06:55

[FIX] account_payment_term_extension: put end of month calculation la…

1c3443c

…st and fix tests

pablo-cort-s73 force-pushed the 19.0-mig-account_payment_term_extension branch from 17e6b27 to 9fd4dd3 Compare January 19, 2026 07:39

Borruso approved these changes Feb 22, 2026

View reviewed changes

[MIG] account_payment_term_extension: Migration to 19.0

ce4e5b5

pablo-cort-s73 force-pushed the 19.0-mig-account_payment_term_extension branch from 9fd4dd3 to ce4e5b5 Compare February 23, 2026 16:17

odooNextev approved these changes Feb 24, 2026

View reviewed changes

Uh oh!

Conversation

pablo-cort-s73 commented Nov 11, 2025

Uh oh!

Reyes4711-S73 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arantxa-s73 left a comment

Choose a reason for hiding this comment

Uh oh!

Reyes4711-S73 commented Nov 12, 2025

Uh oh!

StefanRijnhart commented Nov 12, 2025

Uh oh!

Reyes4711-S73 commented Nov 12, 2025

Uh oh!

OCA-git-bot commented Nov 18, 2025

Uh oh!

etobella Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

pedrobaeza Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

pablo-cort-s73 Nov 27, 2025

Choose a reason for hiding this comment

Uh oh!

pedrobaeza commented Nov 27, 2025

Uh oh!

odooNextev commented Jan 16, 2026

Uh oh!

pablo-cort-s73 commented Jan 19, 2026

Uh oh!

Borruso left a comment

Choose a reason for hiding this comment

Uh oh!

pablo-cort-s73 commented Feb 23, 2026

Uh oh!

odooNextev commented Feb 23, 2026

Uh oh!

pablo-cort-s73 commented Feb 23, 2026

Uh oh!

odooNextev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

Reyes4711-S73 left a comment •

edited

Loading