[16.0][MIG] account_payment_mode_auto_reconcile: Migrate to version 16.0 by sonhd91 · Pull Request #537 · OCA/account-reconcile

sonhd91 · 2023-03-10T08:14:03Z

account.invoice removed use account.move instead. Since payment_mode_id computed by filtered out lines with existed credits/debit, so we use the same that logic in line 57
amount_residual now include the tax_price, so we recal amount_residual

grindtildeath · 2023-06-09T17:31:44Z

@sonhd91 can you please rebase to have a runboat to test?

grindtildeath · 2023-06-12T16:17:25Z

@sonhd91 Look to work well, thx 👍

However, the view on invoices looks broken with the alert message message not displayed properly, can you please fix? 🙏
On v16 runbot:

sonhd91 · 2023-06-15T12:06:31Z

@sonhd91 Look to work well, thx 👍

However, the view on invoices looks broken with the alert message message not displayed properly, can you please fix? 🙏 On v16 runbot:

I updated it, please check again

rousseldenis · 2023-09-04T07:26:25Z

@sonhd91 Could you rebase ?

rousseldenis

Code and functional review

github-actions · 2024-05-05T12:14:48Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

Override write instead of using onchange Add missing utf-8 comment Fix warning message Restrict to customer invoices Add readme and load tests Improvements after reviews Improve doc Unreconcile only automatically reconciled payments

* Add auto reconcile only same journal Add an option to auto reconcile only credits that are on the same journal than the invoice. This make sure that unrelated payment will not be used automatically. * Update account_payment_mode_auto_reconcile/models/account_invoice.py Co-Authored-By: Akim Juillerat <akim.juillerat@camptocamp.com> * Update account_payment_mode_auto_reconcile/tests/test_partner_auto_reconcile.py Co-Authored-By: Akim Juillerat <akim.juillerat@camptocamp.com>

This small change is needed since action_invoice_open filters invoices that can be open from other invoices that cannot. Therefore using invoice_validate here allows for better customizations by ensuring that the invoices to be handled are really open (i.e. have a move generated).

As using reverse is not reliable to ensure oldest credits will be reconciled first, use a function to sort the dicts according to their id and allows inheritance.

sonhd91 · 2024-05-06T03:37:29Z

Code and functional review

@rousseldenis
Sorry, I missed this, branch rebased

OCA-git-bot · 2024-05-12T13:00:01Z

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

github-actions · 2024-09-15T12:18:07Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

grindtildeath · 2024-10-21T12:54:56Z

account_payment_mode_auto_reconcile/models/account_move.py

-        states={"draft": [("readonly", False)], "open": [("readonly", False)]}
+        states={"draft": [("readonly", False)], "posted": [("readonly", False)]}


Do we still need this? AFAIU it means readonly is only applied on cancel?

grindtildeath · 2024-10-21T12:58:19Z

account_payment_mode_auto_reconcile/models/account_move.py

                    continue
-                payment_mode = invoice.payment_mode_id
+                invoice_lines = invoice.line_ids.filtered(
+                    lambda line: line.account_type == "asset_receivable"


Not sure about that one, but somehow you're restricting this feature to customer invoices. I guess it would make more sense to use the filtering on payment term lines?

invoice_lines = invoice.line_ids.filtered(lambda l: l.display_type == 'payment_term')

grindtildeath · 2024-10-21T13:01:08Z

account_payment_mode_auto_reconcile/models/account_move.py

    def auto_reconcile_credits(self, partial_allowed=True):
        for invoice in self:
-            if not invoice.has_outstanding:
+            invoice._compute_payments_widget_to_reconcile_info()


It seems weird to me that you have to explicitely call this before accessing the value 😕

grindtildeath · 2024-10-21T13:10:26Z

account_payment_mode_auto_reconcile/tests/test_partner_auto_reconcile.py

+        )
+        refund_id = cls.refund_wiz.reverse_moves().get("res_id")
+        cls.refund = cls.env["account.move"].browse(refund_id)
+        cls.payment = cls.env["account.payment"].create(


Why do you need to create a payment here? 🤔

grindtildeath · 2024-10-21T13:12:19Z

account_payment_mode_auto_reconcile/tests/test_partner_auto_reconcile.py

+        self.invoice_copy.button_draft()
        self.invoice_copy.write({"payment_mode_id": False})
-        self.assertEqual(self.invoice_copy.residual, 1500)
-        self.assertEqual(auto_rec_invoice.state, "paid")


IMO you should still assert invoice was paid.

thienvh332 · 2024-10-23T03:12:31Z

Hi @grindtildeath ,
I have created #735 to update the changes from your review. Could you have a look it?

sonhd91 marked this pull request as ready for review March 10, 2023 08:16

sonhd91 mentioned this pull request Mar 16, 2023

Migration to version 16.0 #497

Open

7 tasks

santostelmo approved these changes Apr 6, 2023

View reviewed changes

sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from 00341af to f440e10 Compare June 10, 2023 03:34

sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from f440e10 to e97a4aa Compare June 15, 2023 06:15

rousseldenis approved these changes Sep 4, 2023

View reviewed changes

OCA-git-bot added the approved label Sep 4, 2023

sbidoul added this to the 16.0 milestone Jan 1, 2024

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 5, 2024

grindtildeath and others added 8 commits May 6, 2024 10:36

Add account_payment_mode_auto_reconcile

23b5931

Override write instead of using onchange Add missing utf-8 comment Fix warning message Restrict to customer invoices Add readme and load tests Improvements after reviews Improve doc Unreconcile only automatically reconciled payments

[FIX] typo in variable name

469a393

FIX: Use function to sort credits

70037fd

As using reverse is not reliable to ensure oldest credits will be reconciled first, use a function to sort the dicts according to their id and allows inheritance.

[ADD] icon.png

f4f22b1

[IMP] account_payment_mode_auto_reconcile: black, isort, prettier

11c853d

[16.0][MIG]account_payment_mode_auto_reconcile: Migrate to version 16.0

17386a6

sonhd91 force-pushed the 16.0-mig-account_payment_mode_auto_reconcile branch from e97a4aa to 17386a6 Compare May 6, 2024 03:36

github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label May 12, 2024

OCA-git-bot added the ready to merge label May 12, 2024

rousseldenis mentioned this pull request Jun 18, 2024

[IMP] account_payment_mode_auto_reconcile: Allows to reconcile same payment mode sonhd91/account-reconcile#7

Open

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 15, 2024

github-actions bot closed this Oct 20, 2024

grindtildeath added migration no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Oct 21, 2024

grindtildeath reopened this Oct 21, 2024

grindtildeath reviewed Oct 21, 2024

View reviewed changes

thienvh332 mentioned this pull request Oct 23, 2024

[16.0][MIG] account_payment_mode_auto_reconcile: Migrate to version 16.0 #735

Closed

		states={"draft": [("readonly", False)], "open": [("readonly", False)]}
		states={"draft": [("readonly", False)], "posted": [("readonly", False)]}

Uh oh!

Conversation

sonhd91 commented Mar 10, 2023

Uh oh!

grindtildeath commented Jun 9, 2023

Uh oh!

grindtildeath commented Jun 12, 2023

Uh oh!

sonhd91 commented Jun 15, 2023

Uh oh!

rousseldenis commented Sep 4, 2023

Uh oh!

rousseldenis left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 5, 2024

Uh oh!

sonhd91 commented May 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OCA-git-bot commented May 12, 2024

Uh oh!

github-actions bot commented Sep 15, 2024

Uh oh!

grindtildeath Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

grindtildeath Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

grindtildeath Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

grindtildeath Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

grindtildeath Oct 21, 2024

Choose a reason for hiding this comment

Uh oh!

thienvh332 commented Oct 23, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Comments

sonhd91 commented May 6, 2024 •

edited

Loading