Skip to content

[16.0][MIG] account_reconcile_restrict_partner_mismatch#596

Open
sbejaoui wants to merge 21 commits intoOCA:16.0from
acsone:16.0-account_reconcile_restrict_partner_mismatch-sbj
Open

[16.0][MIG] account_reconcile_restrict_partner_mismatch#596
sbejaoui wants to merge 21 commits intoOCA:16.0from
acsone:16.0-account_reconcile_restrict_partner_mismatch-sbj

Conversation

@sbejaoui
Copy link
Contributor

@sbejaoui sbejaoui commented Sep 29, 2023 •
edited
Loading

Iryna Vyshnevska and others added 17 commits September 29, 2023 15:07
@sbejaoui
[12.0][ADD] create addon: account_reconcile_restrict_partner_mismatch
35fcc62
@sbejaoui
[MIG][12.0] adapt tests to v12
1e95397
@MiquelRForgeFlow @sbejaoui
[FIX] Add description to a model
a692ea1
@ernestotejeda @sbejaoui
[IMP] account_reconcile_restrict_partner_mismatch: black, isort
eb17203
@ernestotejeda @sbejaoui
[MIG] account_reconcile_restrict_partner_mismatch: Migration to 13.0
ac3e238
@MiquelRForgeFlow @sbejaoui
[IMP] account_partner_reconcile: black, isort, prettier
e6c7f97
@sbejaoui
[IMP] account_reconcile_restrict_partner_mismatch: black, isort, pret…
c2aa466 
…tier
@sbejaoui
[MIG] account_reconcile_restrict_partner_mismatch: Migration to 14.0
955e699
@oca-travis @sbejaoui
[UPD] Update account_reconcile_restrict_partner_mismatch.pot
4f13a26
@OCA-git-bot @sbejaoui
[UPD] README.rst
e90b533
@ibuioli @sbejaoui
Added translation using Weblate (Spanish (Argentina))
da7389c
@ibuioli @sbejaoui
Translated using Weblate (Spanish (Argentina))
5801f42 
Currently translated at 100.0% (17 of 17 strings)

Translation: account-reconcile-14.0/account-reconcile-14.0-account_reconcile_restrict_partner_mismatch
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-14-0/account-reconcile-14-0-account_reconcile_restrict_partner_mismatch/es_AR/
@ofonseca-pyming @sbejaoui
Added translation using Weblate (Spanish)
6a27d40
@ofonseca-pyming @sbejaoui
Translated using Weblate (Spanish)
16f8fc8 
Currently translated at 100.0% (17 of 17 strings)

Translation: account-reconcile-14.0/account-reconcile-14.0-account_reconcile_restrict_partner_mismatch
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-14-0/account-reconcile-14-0-account_reconcile_restrict_partner_mismatch/es/
@LudLaf @sbejaoui
Translated using Weblate (Spanish)
fea11a0 
Currently translated at 100.0% (17 of 17 strings)

Translation: account-reconcile-14.0/account-reconcile-14.0-account_reconcile_restrict_partner_mismatch
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-14-0/account-reconcile-14-0-account_reconcile_restrict_partner_mismatch/es/
@kaynnan @sbejaoui
[MIG] account_reconcile_restrict_partner_mismatch: Migration to 15.0
337f898
@sbejaoui
[16.0][MIG] account_reconcile_restrict_partner_mismatch
d79fd0d
@sbidoul sbidoul added this to the 16.0 milestone Jan 1, 2024
@grindtildeath
Copy link
Contributor

grindtildeath commented Jan 29, 2024

/ocabot migration account_reconcile_restrict_partner_mismatch

@OCA-git-bot OCA-git-bot mentioned this pull request Jan 29, 2024
Open
7 tasks
@github-actions
Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@github-actions github-actions bot closed this Jul 7, 2024
@rousseldenis
Copy link
Contributor

rousseldenis commented Nov 5, 2024

@OCA/accounting-maintainers Could you reopen this? Thanks

@grindtildeath grindtildeath reopened this Nov 5, 2024
@rousseldenis
Copy link
Contributor

rousseldenis commented Nov 6, 2024

@i-vyshnevska

@rousseldenis
[IMP] account_reconcile_restrict_partner_mismatch: Avoid restriction …
25e64ed 
…on some journals / Enable on company level

In some cases, accounting users should be allowed to mix partners. This will be configured
on account journal level.

In order to not break standard behaviors, the restriction feature should be
enabled by a configuration parameter on company level. A new configuration
parameter has been added.
@rousseldenis rousseldenis force-pushed the 16.0-account_reconcile_restrict_partner_mismatch-sbj branch from 88c36fa to 25e64ed Compare November 6, 2024 10:07
@rousseldenis
Copy link
Contributor

rousseldenis commented Nov 6, 2024

@vuwnevska

@rousseldenis
[IMP] account_reconcile_restrict_partner_mismatch: Test correct excep…
82929e3 
…tions / tests improvements

As accounting entries should be posted before reconciliation, test
correct exceptions.

Improvement to use BaseCommon class in tests
@rousseldenis
Copy link
Contributor

rousseldenis commented Nov 6, 2024 •
edited
Loading

@grindtildeath @fclementic2c @vrenaville

I've improved the module and fixed tests. The feature is activable per company and can be deactivated on some journals.

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Nov 10, 2024
@LucasTran380381 LucasTran380381 mentioned this pull request Nov 12, 2024
Merged
grindtildeath
grindtildeath approved these changes Dec 16, 2024
View reviewed changes
Copy link
Contributor

@grindtildeath grindtildeath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Thanks for the improvements @rousseldenis

@github-actions
Copy link

github-actions bot commented Apr 20, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Apr 20, 2025
@github-actions github-actions bot closed this May 25, 2025
@lfreeke
Copy link

lfreeke commented Dec 15, 2025

This went to stale and then closed, but I do think this can be merged in.

Is there something we can do to open this merge request again?

@grindtildeath grindtildeath reopened this Dec 16, 2025
@grindtildeath
Copy link
Contributor

grindtildeath commented Dec 16, 2025

@lfreeke feel free to review 🙏

@grindtildeath grindtildeath added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grindtildeath grindtildeath grindtildeath approved these changes

Assignees

No one assigned

Labels

no stale Use this label to prevent the automated stale action from closing this PR/Issue.

Projects

None yet

Milestone

16.0

Development

Successfully merging this pull request may close these issues.

Comments