Skip to content

[18.0][FIX] account_mass_reconcile: writeoff with currencies of opposite signs#901

Closed
dcatarino wants to merge 91 commits intoOCA:18.0from
dcatarino:dcatarino_mass_reconcile_fix
Closed

[18.0][FIX] account_mass_reconcile: writeoff with currencies of opposite signs#901
dcatarino wants to merge 91 commits intoOCA:18.0from
dcatarino:dcatarino_mass_reconcile_fix

Conversation

@dcatarino
Copy link

@dcatarino dcatarino commented Jul 28, 2025 •
edited
Loading

This PR applies a fix on the migration of #817 (version 18.0 - still unmerged)

The issue is described on this PR: #831 (version 17.0)

mdietrichc2c and others added 30 commits March 26, 2025 18:50
@mdietrichc2c @amkarthik
Merge and migrate account_easy_reconcile and account_advanced_reconcile
c368d1b
@oca-transbot @amkarthik
OCA Transbot updated translations from Transifex
e9bed0a
@sbidoul @amkarthik
[FIX] account_mass_reconcile: remove en.po that was erroneously creat…
e3a0b76 
…ed by transbot
@florian-dacosta @amkarthik
[FIX] account_mass_reconcile: Fix writeoff variables passed to reconc…
6a6ad14 
…ile method
@pedrobaeza @amkarthik
[MIG] account_mass_reconcile: Make modules uninstallable
6984cfd
@pedrobaeza @amkarthik
[MIG] account_mass_reconcile: Rename manifest files
e5fd0bc
@mdietrichc2c @amkarthik
[FIX] account_mass_reconcile: Remove now non-existing "Display partia…
01e3d11 
…l" button
@grindtildeath @amkarthik
[MIG] account_mass_reconcile: Init mgration to 10.0
c3f38c8
@amkarthik
[MIG] account_mass_reconcile: Migration to odoo 11
86e4d0d
@MiquelRForgeFlow @amkarthik
[FIX] Readme display
6928a3c
@MiquelRForgeFlow @amkarthik
[FIX] Super call on static methods
0838519
@MiquelRForgeFlow @amkarthik
[FIX] Deprecated icon on some buttons
848c33f
@JordiBForgeFlow @amkarthik
account_mass_reconcile: fix in python3 code conversion
75ee160
@osoul-dev @amkarthik
Translated using Weblate (Arabic)
b0c4062 
Currently translated at 78.2% (68 of 87 strings)

Translation: account-reconcile-11.0/account-reconcile-11.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-11-0/account-reconcile-11-0-account_mass_reconcile/ar/
@MiquelRForgeFlow @amkarthik
[ADD] account_mass_reconcile: assure migration is ok
9439577
@AdriaGForgeFlow @amkarthik
[12.0][MIG] Migrate module account_mass_reconcile to v12
43741f3
@oca-transbot @amkarthik
Update translation files
23a6e19 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-12.0/account-reconcile-12.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-12-0/account-reconcile-12-0-account_mass_reconcile/
@amkarthik
[IMP] aditional depndency to trigger recompute properly
d6e55d5
@grindtildeath @amkarthik
Revert "Merge pull request OCA#276 from i-vyshnevska/12.0-account_mas…
98df2f6 
…s_reconcile_transaction_ref"

This reverts commit 16832c3, reversing
changes made to 7da5686.
@AdriaGForgeFlow @amkarthik
[IMP] account_mass_reconcile: black, isort
bc79ec7
@AdriaGForgeFlow @amkarthik
[MIG] account_mass_reconcile: Migration to 13.0
3f462ea
@oca-transbot @amkarthik
Update translation files
a6d6956 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-13.0/account-reconcile-13.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-13-0/account-reconcile-13-0-account_mass_reconcile/
@bosd @amkarthik
Translated using Weblate (Dutch)
e355c37 
Currently translated at 54.8% (57 of 104 strings)

Translation: account-reconcile-13.0/account-reconcile-13.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-13-0/account-reconcile-13-0-account_mass_reconcile/nl/
@florian-dacosta @amkarthik
[IMP] account_mass_reconcile: black, isort, prettier
587b9a4
@florian-dacosta @amkarthik
[MIG] account_mass_reconcile: Migration to 14.0
9242764
@florian-dacosta @amkarthik
Manage write off, some refactore to manage better currency, partial r…
cecedbd 
…econciliation, and add some tests

Also add an advanced reconciliation method based on name. Could be very useful to actually match account move line based
on payment_reference field on invoices, as it is passed to account move line on name field
@ibuioli @amkarthik
Translated using Weblate (Spanish (Argentina))
0d3e861 
Currently translated at 100.0% (104 of 104 strings)

Translation: account-reconcile-14.0/account-reconcile-14.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-14-0/account-reconcile-14-0-account_mass_reconcile/es_AR/
@kittiu @amkarthik
[13.0][FIX] account_mass_reoncile, mass reoncile only posted entry
227bf90
@OCA-git-bot @amkarthik
account_mass_reconcile 14.0.1.0.1
c6643b1
@OCA-git-bot @amkarthik
[IMP] update dotfiles [ci skip]
d6400ab
weblate and others added 25 commits March 26, 2025 18:50
@weblate @amkarthik
Update translation files
a3e33b3 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-16.0/account-reconcile-16.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_mass_reconcile/
@florian-dacosta @amkarthik
[FIX] account_mass_reconcile : fix write-off with todays date
463d92a
@OCA-git-bot @amkarthik
[BOT] post-merge updates
aaf1536
@jakobkrabbe @amkarthik
Translated using Weblate (Swedish)
0bba101 
Currently translated at 100.0% (99 of 99 strings)

Translation: account-reconcile-16.0/account-reconcile-16.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-16-0/account-reconcile-16-0-account_mass_reconcile/sv/
@JasminSForgeFlow @amkarthik
[IMP] account_mass_reconcile: black, isort, prettier
ce6bc7d
@JasminSForgeFlow @amkarthik
[MIG] account_mass_reconcile: Migration to 17.0
395163d
@amkarthik
[UPD] Update account_mass_reconcile.pot
78bcda9
@OCA-git-bot @amkarthik
[BOT] post-merge updates
63ae252
@weblate @amkarthik
Update translation files
41418f2 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-17.0/account-reconcile-17.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_mass_reconcile/
@weblate @amkarthik
Update translation files
39af36b 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-17.0/account-reconcile-17.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_mass_reconcile/
@mymage @amkarthik
Translated using Weblate (Italian)
3995760 
Currently translated at 89.7% (88 of 98 strings)

Translation: account-reconcile-17.0/account-reconcile-17.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_mass_reconcile/it/
@mymage @amkarthik
Translated using Weblate (Italian)
6241f48 
Currently translated at 100.0% (98 of 98 strings)

Translation: account-reconcile-17.0/account-reconcile-17.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_mass_reconcile/it/
@mymage @amkarthik
Translated using Weblate (Italian)
0311cdc 
Currently translated at 100.0% (98 of 98 strings)

Translation: account-reconcile-17.0/account-reconcile-17.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_mass_reconcile/it/
@pedrobaeza @amkarthik
[FIX] *: pre-commit fixes
9184b17 
Due to latest copier template with all the checks.
@OCA-git-bot @amkarthik
[BOT] post-merge updates
30b8250
@jakobkrabbe @amkarthik
Translated using Weblate (Swedish)
2034209 
Currently translated at 100.0% (98 of 98 strings)

Translation: account-reconcile-17.0/account-reconcile-17.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_mass_reconcile/sv/
@xtanuiha @amkarthik
Translated using Weblate (Chinese (Simplified) (zh_CN))
30285c2 
Currently translated at 100.0% (98 of 98 strings)

Translation: account-reconcile-17.0/account-reconcile-17.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_mass_reconcile/zh_CN/
@amkarthik
[UPD] Update account_mass_reconcile.pot
b01ce0c
@weblate @amkarthik
Update translation files
6dafded 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: account-reconcile-17.0/account-reconcile-17.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_mass_reconcile/
@metingulsoy @amkarthik
Translated using Weblate (Turkish)
c462704 
Currently translated at 98.9% (96 of 97 strings)

Translation: account-reconcile-17.0/account-reconcile-17.0-account_mass_reconcile
Translate-URL: https://translation.odoo-community.org/projects/account-reconcile-17-0/account-reconcile-17-0-account_mass_reconcile/tr/
@pedrobaeza @amkarthik
[I18N] account_mass_reconcile: Incorrect Turkish translation
a521014
@amkarthik
[IMP] account_mass_reconcile: black, isort, prettier
5af8e4a
@amkarthik
[MIG] account_mass_reconcile: Migration to 18.0
2b567a5
@dcatarino
[IMP] account_mass_reconcile: add test for reconcile with writeoff cu…
1e48b6d 
…rrency and opposite signs
@dcatarino
[FIX] account_mass_reconcile: reconcile with writeoff currency and op…
eb06be5 
…posite signs
@dcatarino dcatarino changed the title Dcatarino mass reconcile fix [18.0][FIX] account_mass_reconcile: writeoff with currencies of opposite signs Jul 28, 2025
StefanRijnhart
StefanRijnhart requested changes Aug 4, 2025
View reviewed changes
Copy link
Member

@StefanRijnhart StefanRijnhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'd need to cherry pick the commits from the 17.0 branch onto your own branch in order to preserve ownership. However, because the target branch is actually the unmerged migration branch, you can review the migration PR, mention the bug fixing 17.0 PR on the migration branch, and if you want to be helpful, propose a PR onto the branch from the migration PR rather than a separate PR here. You should also review the bug fixing 17.0 PR.

@github-actions
Copy link

github-actions bot commented Dec 7, 2025

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 7, 2025
@github-actions github-actions bot closed this Jan 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StefanRijnhart StefanRijnhart StefanRijnhart requested changes

Assignees

No one assigned

Labels

stale PR/Issue without recent activity, it'll be soon closed automatically.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Comments