[MIG] account_payment_partner: Migration to version 18.0

Author: carlos-lopez-tecnativa

account_payment_partner/demo/partner_demo.xml

@@ -3,11 +3,23 @@
     <function
         model="ir.default"
         name="set"
-        eval="('res.partner', 'supplier_payment_mode_id', ref('account_payment_mode.payment_mode_outbound_ct1'))"
+        eval="(
+            'res.partner',
+            'supplier_payment_mode_id',
+            ref('account_payment_mode.payment_mode_outbound_ct1'),
+            False,
+            ref('base.main_company')
+        )"
     />
     <function
         model="ir.default"
         name="set"
-        eval="('res.partner', 'customer_payment_mode_id', ref('account_payment_mode.payment_mode_inbound_ct1'))"
+        eval="(
+            'res.partner',
+            'customer_payment_mode_id',
+            ref('account_payment_mode.payment_mode_inbound_ct1'),
+            False,
+            ref('base.main_company')
+        )"
     />
 </odoo>

account_payment_partner/models/account_move.py

@@ -21,18 +21,13 @@ class AccountMove(models.Model):
         store=True,
         ondelete="restrict",
         readonly=False,
+        precompute=True,
         check_company=True,
         tracking=True,
     )
     bank_account_required = fields.Boolean(
         related="payment_mode_id.payment_method_id.bank_account_required", readonly=True
     )
-    partner_bank_id = fields.Many2one(
-        compute="_compute_partner_bank_id",
-        store=True,
-        ondelete="restrict",
-        readonly=False,
-    )
     has_reconciled_items = fields.Boolean(
         help="Technical field for supporting the editability of the payment mode",
         compute="_compute_has_reconciled_items",
@@ -160,6 +155,7 @@ def partner_banks_to_show(self):
                 return self.payment_mode_id.variable_journal_ids.mapped(
                     "bank_account_id"
                 )
+        # TODO: move this code to the account_banking_mandate module
         if (
             self.payment_mode_id.payment_method_id.code == "sepa_direct_debit"
         ):  # pragma: no cover

account_payment_partner/reports/account_invoice_report.py

@@ -1,7 +1,8 @@
 # Copyright 2021 Tecnativa - Víctor Martínez
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import fields, models
+from odoo import api, fields, models
+from odoo.tools import SQL
 
 
 class AccountInvoiceReport(models.Model):
@@ -13,6 +14,6 @@ class AccountInvoiceReport(models.Model):
         readonly=True,
     )
 
-    def _select(self):
-        select_str = super()._select()
-        return self.env._("%s, move.payment_mode_id AS payment_mode_id") % select_str
+    @api.model
+    def _select(self) -> SQL:
+        return SQL("%s, move.payment_mode_id AS payment_mode_id", super()._select())

account_payment_partner/tests/test_account_payment_partner.py

@@ -2,30 +2,25 @@
 # Copyright 2021 Tecnativa - Víctor Martínez
 # License AGPL-3.0 or later (https://www.gnu.org/licenses/lgpl.html).
 
-from odoo import _, fields
+from odoo import Command, _, fields
 from odoo.exceptions import UserError, ValidationError
-from odoo.fields import Date
-from odoo.tests import Form, TransactionCase, tagged
+from odoo.tests import Form, tagged
 
-from odoo.addons.base.tests.common import DISABLED_MAIL_CONTEXT
+from odoo.addons.base.tests.common import BaseCommon
 
 
 @tagged("-at_install", "post_install")
-class TestAccountPaymentPartner(TransactionCase):
+class TestAccountPaymentPartner(BaseCommon):
     @classmethod
     def setUpClass(cls):
         super().setUpClass()
-        cls.env = cls.env(context=dict(cls.env.context, **DISABLED_MAIL_CONTEXT))
-
         cls.res_users_model = cls.env["res.users"]
         cls.move_model = cls.env["account.move"]
         cls.journal_model = cls.env["account.journal"]
         cls.payment_mode_model = cls.env["account.payment.mode"]
         cls.partner_bank_model = cls.env["res.partner.bank"]
-
         # Refs
         cls.company = cls.env.ref("base.main_company")
-
         cls.company_2 = cls.env["res.company"].create({"name": "Company 2"})
         chart = cls.env["account.chart.template"]._guess_chart_template(
             cls.company.country_id
@@ -41,7 +36,6 @@ def setUpClass(cls):
         cls.manual_out = cls.env.ref("account.account_payment_method_manual_out")
         cls.manual_out.bank_account_required = True
         cls.manual_in = cls.env.ref("account.account_payment_method_manual_in")
-
         cls.journal_sale = cls.env["account.journal"].create(
             {
                 "name": "Test Sales Journal",
@@ -50,7 +44,6 @@ def setUpClass(cls):
                 "company_id": cls.company.id,
             }
         )
-
         cls.journal_purchase = cls.env["account.journal"].create(
             {
                 "name": "Test Purchases Journal",
@@ -59,7 +52,6 @@ def setUpClass(cls):
                 "company_id": cls.company.id,
             }
         )
-
         cls.journal_c1 = cls.journal_model.create(
             {
                 "name": "J1",
@@ -69,7 +61,6 @@ def setUpClass(cls):
                 "bank_acc_number": "123456",
             }
         )
-
         cls.journal_c2 = cls.journal_model.create(
             {
                 "name": "J2",
@@ -79,7 +70,6 @@ def setUpClass(cls):
                 "bank_acc_number": "552344",
             }
         )
-
         cls.supplier_payment_mode = cls.payment_mode_model.create(
             {
                 "name": "Suppliers Bank 1",
@@ -91,7 +81,6 @@ def setUpClass(cls):
                 "variable_journal_ids": [(6, 0, [cls.journal_c1.id])],
             }
         )
-
         cls.supplier_payment_mode_c2 = cls.payment_mode_model.create(
             {
                 "name": "Suppliers Bank 2",
@@ -102,7 +91,6 @@ def setUpClass(cls):
                 "variable_journal_ids": [(6, 0, [cls.journal_c2.id])],
             }
         )
-
         cls.customer_payment_mode = cls.payment_mode_model.create(
             {
                 "name": "Customers to Bank 1",
@@ -117,7 +105,6 @@ def setUpClass(cls):
         cls.supplier_payment_mode.write(
             {"refund_payment_mode_id": cls.customer_payment_mode.id}
         )
-
         cls.customer = (
             cls.env["res.partner"]
             .with_company(cls.company.id)
@@ -128,7 +115,6 @@ def setUpClass(cls):
                 }
             )
         )
-
         cls.supplier = (
             cls.env["res.partner"]
             .with_company(cls.company.id)
@@ -148,18 +134,17 @@ def setUpClass(cls):
         cls.supplier.with_company(
             cls.company_2.id
         ).supplier_payment_mode_id = cls.supplier_payment_mode_c2
-
         cls.invoice_account = cls.env["account.account"].search(
             [
                 ("account_type", "=", "liability_payable"),
-                ("company_id", "in", cls.company.id),
+                ("company_ids", "in", cls.company.ids),
             ],
             limit=1,
         )
         cls.invoice_line_account = cls.env["account.account"].search(
             [
                 ("account_type", "=", "expense"),
-                ("company_id", "in", cls.company.id),
+                ("company_ids", "in", cls.company.ids),
             ],
             limit=1,
         )
@@ -212,7 +197,7 @@ def _create_invoice(self, default_move_type, partner):
             self.env["account.move"].with_context(default_move_type=default_move_type)
         )
         move_form.partner_id = partner
-        move_form.invoice_date = Date.today()
+        move_form.invoice_date = fields.Date.today()
         with move_form.invoice_line_ids.new() as line_form:
             line_form.product_id = self.product
             line_form.name = "product that cost 100"
@@ -351,9 +336,7 @@ def test_payment_mode_constrains_02(self):
                 "ref": "reference",
                 "state": "draft",
                 "invoice_line_ids": [
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "account_id": self.invoice_account.id,
                             "credit": 1000,
@@ -362,9 +345,7 @@ def test_payment_mode_constrains_02(self):
                             "ref": "reference",
                         },
                     ),
-                    (
-                        0,
-                        0,
+                    Command.create(
                         {
                             "account_id": self.invoice_line_account.id,
                             "credit": 0,

account_payment_partner/views/account_move_line.xml

@@ -31,7 +31,7 @@
                     name="payment_mode_id"
                     optional="hide"
                     force_save="1"
-                    invisible="account_type not in ['asset_receivable', 'liability_payable']"
+                    column_invisible="account_type not in ['asset_receivable', 'liability_payable']"
                     readonly="account_type not in ['asset_receivable', 'liability_payable'] or reconciled"
                 />
             </field>

account_payment_partner/views/res_partner_view.xml

@@ -10,10 +10,16 @@
         <field name="inherit_id" ref="account.view_partner_property_form" />
         <field name="arch" type="xml">
             <field name="property_payment_term_id" position="after">
-                <field name="customer_payment_mode_id" widget="selection" />
+                <field
+                    name="customer_payment_mode_id"
+                    options="{'no_open': True, 'no_create': True}"
+                />
             </field>
             <field name="property_supplier_payment_term_id" position="after">
-                <field name="supplier_payment_mode_id" widget="selection" />
+                <field
+                    name="supplier_payment_mode_id"
+                    options="{'no_open': True, 'no_create': True}"
+                />
             </field>
         </field>
     </record>