[16.0][IMP] account_payment_mode: change type of payment_mode.note field

[clementelabore]

Change type of payment_mode.note from Text to Html
This to improve display on Invoice document

[pedrobaeza]

I see this improvement as something good, but you should provide a migration script for converting previous content to HTML. There's an openupgradelib method for that.

[clementelabore]

I hope it was the right way to do it ;)

[pedrobaeza]

I'm afraid not. That's a hook, not a migration script. A sample (not with the same change though): https://github.com/OCA/contract/tree/16.0/contract/migrations

[clementelabore]

it should be ok when OCA/openupgradelib#384 will be merged

[pedrobaeza]

Please squash commits into one

[pedrobaeza]

Thanks for all the changes.

This must be merged with major switch in the ocabot merge command

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[pedrobaeza]

Rescuing this:

/ocabot merge major

[OCA-git-bot]

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-1360-by-pedrobaeza-bump-major, awaiting test results.

[OCA-git-bot]

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-1360-by-pedrobaeza-bump-major.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

[pedrobaeza]

@AnizR can you please check the problem with your module account_payment_method_fs_storage?

https://github.com/OCA/bank-payment/actions/runs/13748693138/job/38446868447?pr=1360#step:8:438

ValueError: External ID not found in the system: fs_storage.default_fs_storage

I think it should be a change in the upstream dependency fs_storage.

[AnizR]

@AnizR can you please check the problem with your module account_payment_method_fs_storage?

https://github.com/OCA/bank-payment/actions/runs/13748693138/job/38446868447?pr=1360#step:8:438

ValueError: External ID not found in the system: fs_storage.default_fs_storage

I think it should be a change in the upstream dependency fs_storage.

I will investigate the issue with the account_payment_method_fs_storage module. However, it seems unusual that the demo data from fs_storage is not accessible during the test execution. Although fs_storage is listed as a dependency in my module, the test runs in the post-install phase, which previously worked without any issues.

[pedrobaeza]

It's better to not use demo data in tests. Demo data may have also any problem being loaded.

[AnizR]

It's better to not use demo data in tests. Demo data may have also any problem being loaded.

I have done the changes: #1430

[pedrobaeza]

/ocabot merge major

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1360-by-pedrobaeza-bump-major, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 50c35bc. Thanks a lot for contributing to OCA. ❤️

[pedrobaeza]

Can you please fw-port it to 17? In this case, the script should check if the column is not JSONB for calling the method.