Skip to content

[18.0][MIG] account_payment_partner: Migration to version 18.0#1439

Merged
OCA-git-bot merged 116 commits intoOCA:18.0from
Tecnativa:18.0-mig-account_payment_partner
Apr 16, 2025
Merged

[18.0][MIG] account_payment_partner: Migration to version 18.0#1439
OCA-git-bot merged 116 commits intoOCA:18.0from
Tecnativa:18.0-mig-account_payment_partner

Conversation

@carlos-lopez-tecnativa
Copy link
Copy Markdown
Contributor

@carlos-lopez-tecnativa carlos-lopez-tecnativa commented Mar 26, 2025

Comment thread account_payment_partner/security/account_payment_partner_security.xml Outdated
@pedrobaeza
Copy link
Copy Markdown
Member

/ocabot migration account_payment_partner

Copy link
Copy Markdown
Contributor

@JordiMForgeFlow JordiMForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

Comment thread account_payment_partner/views/res_partner_view.xml
@sergioM-S73
Copy link
Copy Markdown

Shouldn't the dependency be added to the module that creates "mandate_id" ?
I'm getting this error when printing an invoice:

image

The module that creates the field in v17 is "account_banking_mandate"

@pedrobaeza
Copy link
Copy Markdown
Member

@sergioM-S73 yes, that part should be extracted outside this one. We will do it after merging account_payment_partner. Anyway, this is not something exclusive of this migration, but dragged from previous ones.

Alexis de Lattre and others added 16 commits April 16, 2025 14:18
- account_payment_partner
- account_payment_sale
- account_payment_sale_stock
- account_payment_purchase

Filter the selection of invoices per payment type.
Add active field on payment.mode and payment.mode.type.
Add menu entry for Payment Types.
* Migration and enhancement of all modules involved in SEPA
* Clean files
* Replace deprecated workflow calls
* Translation template files
* Translations to spanish
* Use sale_ok and purchase_ok instead of tweaking payment type
* IMP: Add filter group by payment mode in account invoices
* FIX: Remove deprecated tag type
* move unused file + cleanup code
* Add sale_ok and purchase_ok filters in partner/sale/purchase form views
* Use widget=selection for payment_mode_id fields
* Update demo data
* Return res in inherit (even if res is empty in this case)
…hout invoice (manual entries in receivables/payables)
* Forgot to remove a usecase of debit_denied
* Add ACL
* Better filters on payment.order.create wizard
* Add default values for those filters on payment.mode
* FIX remove coma at end of line
* Add translatable 'label' field on payment.mode, designed to be used in invoice report
* Short headers
* Remove label field

  There's already a field in the payment mode called 'note' that is
  printed on the invoices, so there's no need of another field for
  that purpose. This field is added by account_banking_payment_export

* Bump version numbers
* es translations
* Name to filter for better inheratiblity
… a lot of improvements) during the Sorrento Code sprint 2016

Improvements include:
- full re-organisation of modules and big re-organisation of the code
- simplification of the code related to the fact that support for direct debit is now in t
he base module, not added by an optional module account_direct_debit (module was removed)
- new design of the wizard to select move lines to pay
- support for non-SEPA file transfer-
- support for German direct debit SEPA files (fixes bug OCA#129)
- remove workflow of payment.order
* Finalise the wizard of selection of move lines to pay
* Add button "Add to payment/debit order" on invoice form view
* Started to integrate payment transfer in account_payment_order (not finished at all though)
* Copy payment mode and mandate from invoice to refund
* Run dos2unix on the few files that had DOS carriage return
* Add _id suffix on M2O fields customer_payment_mode and supplier_payment_mode (Odoo did the same on all the M2O property fields of res.partner)
* Better handling of partner_bank_id and mandate_id on invoice: invisible/required/onchange
* Move field bank_account_required from module account_payment_partner to account_payment_mode
remi-filament and others added 18 commits April 16, 2025 14:18
Currently translated at 100.0% (37 of 37 strings)

Translation: bank-payment-16.0/bank-payment-16.0-account_payment_partner
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-16-0/bank-payment-16-0-account_payment_partner/fr/
Currently translated at 100.0% (37 of 37 strings)

Translation: bank-payment-17.0/bank-payment-17.0-account_payment_partner
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_partner/it/
…ions in HTML module descriptions are deprecated since Odoo 17
Currently translated at 100.0% (37 of 37 strings)

Translation: bank-payment-17.0/bank-payment-17.0-account_payment_partner
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_partner/sv/
- Include context keys for avoiding mail operations overhead.
Currently translated at 100.0% (37 of 37 strings)

Translation: bank-payment-17.0/bank-payment-17.0-account_payment_partner
Translate-URL: https://translation.odoo-community.org/projects/bank-payment-17-0/bank-payment-17-0-account_payment_partner/it/
…invoices

This error is happening because the salesperson has not access to payment_method_id.

With this changes we avoid the error and the invoices are printed like normally.

TT31296
@carlos-lopez-tecnativa carlos-lopez-tecnativa force-pushed the 18.0-mig-account_payment_partner branch from befd64b to e84f27e Compare April 16, 2025 19:19
…_mandate

TODO: move this code to the account_banking_mandate module
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As for now, there seems to be a "fork", we don't dig more on the fields UI, just the current visibility group over core fields. If this changes in the future, we can open improvement PRs.

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-1439-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit e4cd15c into OCA:18.0 Apr 16, 2025
4 of 6 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 3b6324b. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 18.0-mig-account_payment_partner branch April 16, 2025 20:09
Vicent-S73 pushed a commit to Studio73/e-commerce that referenced this pull request Aug 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.