[17.0][FIX] account_*: Adapt tests to odoo new banks flow#1564
[17.0][FIX] account_*: Adapt tests to odoo new banks flow#1564OCA-git-bot merged 4 commits intoOCA:17.0from
Conversation
|
Will add here the fixes for other modules from the repo |
christian-ramos-tecnativa
changed the title
| # The partner bank should be set as odoo made posible | ||
| # to assign not allow_out_payment bank account | ||
| # more info https://github.com/odoo/odoo/commit/1794fce234735ed174599891435d4e2accc16324 | ||
| self.assertTrue(move_form.partner_bank_id) |
There was a problem hiding this comment.
Why is this and the next ones changing? We want to not have a bank account assigned. Maybe you need to change the parameter at company level, or test both.
There was a problem hiding this comment.
Because the bank_partner in this case YourCompany has the bank_ids created with demo data https://github.com/OCA/bank-payment/blob/17.0/account_payment_mode/demo/payment_demo.xml#L36, before the change those banks account were not allowed so none of them get selected now it takes de first one https://github.com/odoo/odoo/blob/17.0/addons/account/models/account_move.py#L897
christian-ramos-tecnativa
force-pushed
the
17.0-fix-account_payment_partner-tests
branch
from
66a0a44 to
76d6ce9
Compare
|
/ocabot merge patch |
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at c70f793. Thanks a lot for contributing to OCA. ❤️ |
5 participants
The commit odoo/odoo@1794fce contains the next changes summarized:
account.group_validate_bank_accountbase.group_systempartner_bank_idcan contain non allow_out_payment banks, but the error will raise on postThis PR adapt the tests to the new bank flow
@Tecnativa TT61155
@carlos-lopez-tecnativa @pilarvargas-tecnativa @pedrobaeza @victoralmau