[18.0][FIX] delivery_price_method: Skip base functionality #1017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rousseldenis Can you check the fix when you can? |
david-s73
changed the title
|
@pedrobaeza Can you check the fix when you can? |
| previous_method = False | ||
| if self.price_method in ("fixed", "base_on_rule"): | ||
| if self.price_method in ("fixed", "base_on_rule") and ( | ||
| not self.free_over or not self.amount or order.amount_total < self.amount |
There was a problem hiding this comment.
Why not using self._compute_currency() as in base code ?
There was a problem hiding this comment.
I understand that you mean changing the order.amount to self._compute_currency() right?
david-s73
force-pushed
the
18.0-fix-delivery_price_method
branch
from
5e360a3 to
ab70172
Compare
If the pricing method is 'rule-based' it does not take into account the ‘free_over’ field so if it receives a price higher than any rule it will get a base error message.
david-s73
force-pushed
the
18.0-fix-delivery_price_method
branch
from
ab70172 to
f564bac
Compare
Vicent-S73
pushed a commit
to Studio73/e-commerce
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
free_overI leave the exact line of the Odoo code, as it is forcing thedelivery_typeto be the same as this in theprice_methodthen does not make theifwhen it should be done.Odoo code