[16.0] [FIX] delivery_dropoff_site: name search in fields pointing to res.partner is broken

[rrebollo]

What is wrong?

☝️ is recorded on runboat.

The issue comes from this code:

delivery-carrier/delivery_dropoff_site/models/res_partner.py

Line 14 in 63ae7c7

_rec_names_search = ["dropoff_site_id"]

What’s done

Following the approach used in other OCA addons, _rec_names_search is now properly set, and everything works as expected.

18.0 isn't been affected. 17.0 hasn't been merged yet (#951) but it is affected.

EDIT

Given that the coverage check was failing, we addressed that as well. Inspired by 18.0 tests.

@BinhexTeam

[rrebollo]

@BhaveshHeliconia check this out. It's affecting your migration to 17.0 as well.

[rrebollo]

You were involved in migration to 16.0. Would you be so kind to review this @jdoutreloux @ThomasBinsfeld @DorianMAG @rousseldenis @gaelTorrecillas @flotho.

[jdoutreloux]

LGTM

[edescalona]

LGTM

[OCA-git-bot]

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

[BhaveshHeliconia]

@rrebollo thanks for the fix. LGTM!

[rrebollo]

@rousseldenis can we proceed with merging this?

[rrebollo]

@pedrobaeza 🙏 I was hoping not to bother you with this, but... could you please merge it? 🚀

[pedrobaeza]

/ocabot merge patch

[OCA-git-bot]

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-1048-by-pedrobaeza-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 3c4b76f. Thanks a lot for contributing to OCA. ❤️