[18.0][FIX] delivery_carrier_pricelist: prevent AccessError
#1062
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilvioC2C
changed the title
AccessErrorAccessError
SilvioC2C
force-pushed
the
FIX-delivery_carrier_pricelist
branch
3 times, most recently
from
d70a47f to
6abc1de
Compare
henrybackman
approved these changes
Oct 20, 2025
simahawk
requested changes
Oct 20, 2025
SilvioC2C
force-pushed
the
FIX-delivery_carrier_pricelist
branch
from
6abc1de to
0c7e835
Compare
SilvioC2C
force-pushed
the
FIX-delivery_carrier_pricelist
branch
from
0c7e835 to
9301fda
Compare
simahawk
reviewed
Oct 21, 2025
|
|
||
| from odoo import api, fields, models | ||
|
|
||
| _logger = getLogger(__name__) |
| if self.invoice_policy != "pricelist" or self.delivery_type == "pricelist": | ||
| return super().rate_shipment(order) | ||
|
|
||
| # Use ``sudo()`` to prevent ``AccessError`` when updating the delivery type |
There was a problem hiding this comment.
IMO we should finally propose a change to odoo core avoid this stuff.
I would propose the addition of _rate_shipment_get_handler instead of using getattr directly.
This way, in v19 or 20 we can get rid of this hack.
Also note that some specific carrier implementation rely on computed fields depending on delivery_type so we might trigger unnecessary changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.