[18.0] [MIG] delivery_postlogistics: Migration to 18.0 #974

StephaneMangin · 2025-02-10T11:18:29Z

Includes:

reusing of "delivery.carrier.template.option" from OCA module "delivery_carrier_option"
reusing of "shipping.label" from OCA module "delivery_carrier_shipping_label" instead of custom "postlogistics.shipping.label"
Add a default package type to fullfill postlogistics_send_shipping requirements (Using ECO default shipping pricing)

Depends on:

Due to some modules overrding the web service and as this implementation doesn't allow to properly chain modules (that could not be chained). An API refactoring has occur to allow to override from the picking instead of the webservice (some prepare methods)

StephaneMangin · 2025-02-10T11:18:43Z

Superseeds #940

yankinmax · 2025-02-14T09:12:13Z

hello @StephaneMangin
There is an issue in migration. You're overriding the selection of the type field declared for delivery.carrier.template.option model in delivery_carrier_option module.
Here is Odoo logs:

WARNING testdb odoo.fields: delivery.carrier.template.option.type: selection=[('label_layout', 'Label Layout'), ('output_format', 'Output Format'), ('resolution', 'Output Resolution'), ('basic', 'Basic Service'), ('additional', 'Additional Service'), ('delivery', 'Delivery Instructions'), ('partner_option', 'Partner Option')] overrides existing selection; use selection_add instead

rousseldenis · 2025-02-14T09:17:46Z

/ocabot migration delivery_postlogistics

delivery_postlogistics/views/stock_package_type_view.xml

delivery_postlogistics/views/stock.xml

delivery_postlogistics/views/delivery.xml

delivery_postlogistics/tests/fixtures/cassettes/test_token_error.yaml

delivery_postlogistics/tests/fixtures/cassettes/test_store_label.yaml

delivery_postlogistics/tests/fixtures/cassettes/test_missing_language.yaml

delivery_postlogistics/tests/common.py

delivery_postlogistics/models/stock_quant_package.py

test-requirements.txt

StephaneMangin · 2025-02-18T13:20:26Z

hello @StephaneMangin There is an issue in migration. You're overriding the selection of the type field declared for delivery.carrier.template.option model in delivery_carrier_option module. Here is Odoo logs:
WARNING testdb odoo.fields: delivery.carrier.template.option.type: selection=[('label_layout', 'Label Layout'), ('output_format', 'Output Format'), ('resolution', 'Output Resolution'), ('basic', 'Basic Service'), ('additional', 'Additional Service'), ('delivery', 'Delivery Instructions'), ('partner_option', 'Partner Option')] overrides existing selection; use selection_add instead

Yes it is transitional, because these values are added in a dependency. Updating...

delivery_postlogistics/models/stock_picking.py

delivery_postlogistics/postlogistics/web_service.py

simahawk · 2025-04-28T13:54:58Z

delivery_postlogistics/__manifest__.py

+    "external_dependencies": {
+        "python": [
+            "openupgradelib",
+            "vcrpy",


@yankinmax vcrpy IS NOT a dep. It's needed only for tests.
Also, please try to respect the commit msg guidelines.
I'm fixing these issues now and merge. I'm also dropping the change on the index.html file.
TIP for devs: export SKIP=oca-gen-addon-readme to disable pre-commit readme update.

@leemannd commit msg issue applies to you as well 😉

Hello @simahawk, I've added vcrpy, because another PR build was failing without this dependency.
I'll check the commit message guideline. I thought I was respecting it.
Thanks for your help on this.

simahawk · 2025-04-28T14:00:44Z

I'm also removing the fix for test dep because it came from the other PR for postlogistics. 10676c6

Avoid loss when several unchained modules implements new behaviors in it.

Package type should be required attribute to be sent to the PostLogistics API.

simahawk · 2025-04-28T14:06:51Z

/ocabot merge nobump

OCA-git-bot · 2025-04-28T14:06:58Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-974-by-simahawk-bump-nobump, awaiting test results.

Signed-off-by simahawk

OCA-git-bot · 2025-04-28T14:09:55Z

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-974-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

simahawk · 2025-05-06T10:42:38Z

/ocabot merge nobump

OCA-git-bot · 2025-05-06T10:42:45Z

This PR looks fantastic, let's merge it!
Prepared branch 18.0-ocabot-merge-pr-974-by-simahawk-bump-nobump, awaiting test results.

Signed-off-by simahawk

OCA-git-bot · 2025-05-06T10:45:42Z

@simahawk your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-974-by-simahawk-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

simahawk · 2025-05-07T05:02:40Z

Sounds like there's an issue w/ a PO file. @leemannd or @bizzappdev (as you are working on #941 ) would you be able to check what's wrong?

bizzappdev · 2025-05-07T05:11:47Z

@simahawk yes sure we will check soon

… updated stock picking.

simahawk · 2025-05-08T05:37:13Z

/ocabot merge nobump

OCA-git-bot · 2025-05-08T05:37:20Z

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-974-by-simahawk-bump-nobump, awaiting test results.

OCA-git-bot · 2025-05-08T05:43:40Z

Congratulations, your PR was merged at ce999a8. Thanks a lot for contributing to OCA. ❤️

This was referenced Feb 10, 2025

[18.0] [MIG] delivery_postlogistics: Migration to 18.0 #940

Closed

[18.0][MIG] delivery_postlogistics_server_env: Migration to 18.0 #972

Merged

StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch 5 times, most recently from 98eb1c9 to 4d44284 Compare February 10, 2025 14:52

OCA-git-bot added this to the 18.0 milestone Feb 14, 2025

OCA-git-bot mentioned this pull request Feb 14, 2025

Migration to version 18.0 #889

Open

36 tasks

yankinmax mentioned this pull request Feb 14, 2025

[18.0][MIG] delivery_carrier_label_batch: Migration to 18.0 #984

Open

3 tasks

jbaudoux reviewed Feb 14, 2025

View reviewed changes

jbaudoux reviewed Feb 17, 2025

View reviewed changes

delivery_postlogistics/models/stock_quant_package.py Show resolved Hide resolved

bizzappdev mentioned this pull request Feb 17, 2025

[18.0] [MIG] delivery_postlogistics_dangerous_goods: Migration to 18.0 #941

Merged

bizzappdev reviewed Feb 17, 2025

View reviewed changes

test-requirements.txt Outdated Show resolved Hide resolved

StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch 4 times, most recently from 3fe8f87 to 78c780f Compare February 18, 2025 14:15

yankinmax reviewed Feb 20, 2025

View reviewed changes

delivery_postlogistics/models/stock_picking.py Outdated Show resolved Hide resolved

StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch 2 times, most recently from 0f171db to 894894d Compare February 21, 2025 14:29

jbaudoux reviewed Feb 25, 2025

View reviewed changes

delivery_postlogistics/postlogistics/web_service.py Outdated Show resolved Hide resolved

jbaudoux reviewed Feb 25, 2025

View reviewed changes

delivery_postlogistics/postlogistics/web_service.py Show resolved Hide resolved

StephaneMangin force-pushed the 18.0-mig-delivery_postlogistics branch 3 times, most recently from e9dc13c to 0b24d58 Compare February 26, 2025 13:58

simahawk reviewed Apr 28, 2025

View reviewed changes

bizzappdev and others added 4 commits April 28, 2025 16:01

[MIG] delivery_postlogistics: Migration to 18.0

355016b

[IMP] delivery_postlogistics: refactor web service api class

349314b

Avoid loss when several unchained modules implements new behaviors in it.

[fix] delivery_postlogistics: v18 migration scripts

e8d9514

[FIX] delivery_postlogistics: package type required

849b999

Package type should be required attribute to be sent to the PostLogistics API.

simahawk force-pushed the 18.0-mig-delivery_postlogistics branch from fb1f316 to 849b999 Compare April 28, 2025 14:01

OCA-git-bot added a commit that referenced this pull request Apr 28, 2025

Merge PR #974 into 18.0

5b668e9

Signed-off-by simahawk

OCA-git-bot added the bot is merging ⏳ label Apr 28, 2025

OCA-git-bot removed the bot is merging ⏳ label Apr 28, 2025

OCA-git-bot added a commit that referenced this pull request May 6, 2025

Merge PR #974 into 18.0

e6f5a6a

Signed-off-by simahawk

OCA-git-bot added the bot is merging ⏳ label May 6, 2025

OCA-git-bot removed the bot is merging ⏳ label May 6, 2025

bizzappdev mentioned this pull request May 7, 2025

[18.0][FIX] delivery_postlogistics: Updated PO file and stock picking for translation. camptocamp/delivery-carrier#4

Merged

[FIX] delivery_postlogistics: Removed duplicate string in po file and…

cd402f8

… updated stock picking.

OCA-git-bot added the bot is merging ⏳ label May 8, 2025

OCA-git-bot merged commit 54db769 into OCA:18.0 May 8, 2025
5 of 7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels May 8, 2025

Uh oh!

[18.0] [MIG] delivery_postlogistics: Migration to 18.0 #974

[18.0] [MIG] delivery_postlogistics: Migration to 18.0 #974

Uh oh!

Conversation

StephaneMangin commented Feb 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

StephaneMangin commented Feb 10, 2025

Uh oh!

yankinmax commented Feb 14, 2025

Uh oh!

rousseldenis commented Feb 14, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

StephaneMangin commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

simahawk Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

yankinmax Apr 28, 2025

Choose a reason for hiding this comment

Uh oh!

simahawk commented Apr 28, 2025

Uh oh!

simahawk commented Apr 28, 2025

Uh oh!

OCA-git-bot commented Apr 28, 2025

Uh oh!

OCA-git-bot commented Apr 28, 2025

Uh oh!

simahawk commented May 6, 2025

Uh oh!

OCA-git-bot commented May 6, 2025

Uh oh!

OCA-git-bot commented May 6, 2025

Uh oh!

simahawk commented May 7, 2025

Uh oh!

bizzappdev commented May 7, 2025

Uh oh!

simahawk commented May 8, 2025

Uh oh!

OCA-git-bot commented May 8, 2025

Uh oh!

Uh oh!

OCA-git-bot commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

27 participants

StephaneMangin commented Feb 10, 2025 •

edited

Loading