[19.0][MIG] website_sale_product_attribute_value_filter_existing by augusto-weiss · Pull Request #1193 · OCA/e-commerce

augusto-weiss · 2026-04-06T17:16:04Z

No description provided.

… to v13

…nt_status

…ort, prettier

… to 14.0

…ort, prettier

… to 15.0 [UPD] Update website_sale_product_attribute_value_filter_existing.pot

…ration to 16.0

…nature match the function signature of shop with the original one from website_sale, to avoid potential issues with other modules overwriting the function and passing unexpected parameters

…to check the real functionality of the module TT45590

…ormance improvement - Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.

…er extraction in mobile view

…ibute parent container If only the attribute container is hidden, the parent container still occupies a space that is visible in the attribute list. To avoid this, apply the condition to the parent container and hide it completely. TT50704

…t auto fixes

… to 18.0 TT51372

…ibute container TT51372

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: e-commerce-18.0/e-commerce-18.0-website_sale_product_attribute_value_filter_existing Translate-URL: https://translation.odoo-community.org/projects/e-commerce-18-0/e-commerce-18-0-website_sale_product_attribute_value_filter_existing/

…erformance using ID sets The overhead of extending the entire "shop()" method is eliminated and the logic is moved to "_get_additional_extra_shop_values()", the hook provided by Odoo to add data to the context without duplicating core code. In addition, the filtering of unused values is optimized by avoiding the intersection of recordsets in QWeb ("attr_values_used & v"). Instead, the IDs of used values are precomputed as a set ("attr_values_used_ids") and the templates check "v.id in attr_values_used_ids", which drastically reduces the cost per iteration.

Copilot

Pull request overview

This PR migrates/adds the website_sale_product_attribute_value_filter_existing addon for Odoo 19.0, aiming to hide product attribute values in the shop filters when they are not used by the currently displayed products.

Changes:

Add a controller hook to compute “used” attribute value ids for the current shop result set.
Apply QWeb template conditions to hide unused attribute values across multiple filter display templates.
Add frontend web tours + an HttpCase to validate the UI behavior, along with generated README/description/i18n scaffolding.

Reviewed changes

Copilot reviewed 19 out of 24 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
website_sale_product_attribute_value_filter_existing/init.py	Initializes the addon Python package (imports controllers).
website_sale_product_attribute_value_filter_existing/manifest.py	Declares addon metadata and registers test assets (web tours).
website_sale_product_attribute_value_filter_existing/controllers/init.py	Exposes the controller module.
website_sale_product_attribute_value_filter_existing/controllers/main.py	Extends `WebsiteSale` to compute and inject `attr_values_used_ids` into shop rendering values.
website_sale_product_attribute_value_filter_existing/views/templates.xml	Adds `t-if` conditions to hide attribute values not in `attr_values_used_ids`.
website_sale_product_attribute_value_filter_existing/tests/init.py	Initializes the test package.
website_sale_product_attribute_value_filter_existing/tests/test_website_sale_product_attribute_value_filter_existing.py	Creates test products/attributes and runs UI tours to validate filter visibility.
website_sale_product_attribute_value_filter_existing/static/src/js/website_sale_product_attribute_value_filter_existing_tour.esm.js	Web tour asserting unused value (“Test yellow”) is hidden on `/shop`.
website_sale_product_attribute_value_filter_existing/static/src/js/website_sale_product_attribute_value_filter_existing_search_desk_tour.esm.js	Web tour asserting values not used in search result set are hidden.
website_sale_product_attribute_value_filter_existing/README.rst	Generated addon README.
website_sale_product_attribute_value_filter_existing/readme/DESCRIPTION.md	Short functional description for README generation.
website_sale_product_attribute_value_filter_existing/readme/CONFIGURATION.rst	User configuration instructions.
website_sale_product_attribute_value_filter_existing/readme/CONTRIBUTORS.md	Contributor listing.
website_sale_product_attribute_value_filter_existing/readme/CREDITS.md	Migration credit note.
website_sale_product_attribute_value_filter_existing/static/description/index.html	Generated long HTML description for Odoo Apps view.
website_sale_product_attribute_value_filter_existing/static/description/icon.png	Addon icon.
website_sale_product_attribute_value_filter_existing/i18n/website_sale_product_attribute_value_filter_existing.pot	Base translation template scaffold.
website_sale_product_attribute_value_filter_existing/i18n/tr.po	Turkish translation scaffold/header.
website_sale_product_attribute_value_filter_existing/i18n/pt_BR.po	Brazilian Portuguese translation scaffold/header.
website_sale_product_attribute_value_filter_existing/pyproject.toml	Packaging build-system metadata (whool).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-06T17:21:04Z

+    def _get_additional_shop_values(self, values, **post):
+        res = super()._get_additional_shop_values(values, **post)
+        search_product = values.get("search_product")
+        attributes = values.get("attributes")
+        if search_product and attributes:
+            ProductTemplateAttributeLine = request.env[


attr_values_used_ids is only added to res when both search_product and attributes are truthy. The inherited QWeb templates always reference attr_values_used_ids, so in cases like an empty result set (or any path where these keys are falsy) this can raise a QWeb rendering error due to an undefined variable. Set a default in res (e.g., False/empty) before the conditional, and then override it when you can compute used values.

Copilot · 2026-04-06T17:21:04Z

+            "/website_sale_product_attribute_value_filter_existing/static/src/js/"
+            "website_sale_product_attribute_value_filter_existing_tour.esm.js",
+            "/website_sale_product_attribute_value_filter_existing/static/src/js/"


The web.assets_tests entries use leading / absolute paths and point to static/src/js. In this repo, other addons register test tours via module-relative static/tests/**/* globs (no leading slash). Using absolute paths / a different folder risks the tours not being loaded by the test asset bundle. Consider moving tours under static/tests/tours/ and registering them with a module-relative glob (or at least drop the leading /).

Suggested change

"/website_sale_product_attribute_value_filter_existing/static/src/js/"

"website_sale_product_attribute_value_filter_existing_tour.esm.js",

"/website_sale_product_attribute_value_filter_existing/static/src/js/"

"website_sale_product_attribute_value_filter_existing/static/src/js/"

"website_sale_product_attribute_value_filter_existing_tour.esm.js",

"website_sale_product_attribute_value_filter_existing/static/src/js/"

Copilot · 2026-04-06T17:21:05Z

+        cls.env["website"].with_context(website_id=website.id).viewref(
+            "website_sale.products_attributes"
+        ).active = True
+        cls.env["website"].with_context(website_id=website.id).viewref(
+            "website_sale.search"


These lines violate the repository's formatting conventions (ruff format / 88-char lines) and will likely fail linting due to overlong lines and inconsistent quoting. Please reformat/split the chained calls and use consistent double quotes.

Suggested change

cls.env["website"].with_context(website_id=website.id).viewref(

"website_sale.products_attributes"

).active = True

cls.env["website"].with_context(website_id=website.id).viewref(

"website_sale.search"

(

cls.env["website"]

.with_context(website_id=website.id)

.viewref("website_sale.products_attributes")

).active = True

(

cls.env["website"]

.with_context(website_id=website.id)

.viewref("website_sale.search")

Copilot · 2026-04-06T17:21:05Z

@@ -0,0 +1,18 @@
+import {registry} from "@web/core/registry";


Import formatting is inconsistent with the repo's Prettier config (bracketSpacing: false). Use import {registry} ... (no spaces) to avoid formatting/lint churn.

Copilot · 2026-04-06T17:21:05Z

+This module extends the functionality of website sale module to allow
+hide product attributes values which exist but not used on any variants.


Grammar in the module description is off (e.g., "to allow hide" / "values which exist but not used"). Please rephrase to something like "to hide product attribute values that exist but are not used on any variants" for clarity.

Suggested change

This module extends the functionality of website sale module to allow

hide product attributes values which exist but not used on any variants.

This module extends the functionality of the website sale module to hide

product attribute values that exist but are not used on any variants.

Copilot · 2026-04-06T17:21:06Z

+* Go to Website Shop
+* Active product attributes filter on theme panel option of shopping page
+    - Click edit button on shopping page (or directly go url: http://{your-domain}/@/shop)
+    - On tab `Customize`, enable attributes filter to show attribute values left of the layout.
+* System only display the attribute values if used.


This configuration text has multiple grammar issues (e.g., "Active" vs "Activate", "System only display"). Please correct wording to be clear and professional for end users.

Suggested change

* Go to Website Shop

* Active product attributes filter on theme panel option of shopping page

- Click edit button on shopping page (or directly go url: http://{your-domain}/@/shop)

- On tab `Customize`, enable attributes filter to show attribute values left of the layout.

* System only display the attribute values if used.

* Go to the Website Shop.

* Activate the product attribute filter in the theme panel options on the shopping page.

- Click the Edit button on the shopping page (or go directly to the URL: http://{your-domain}/@/shop).

- On the `Customize` tab, enable the attribute filter to show attribute values on the left side of the layout.

* The system displays only the attribute values that are in use.

… to 19.0

CarlosRoca13 and others added 29 commits April 6, 2026 12:49

[IMP] : black, isort, prettier

0f13e7a

[MIG] website_sale_product_attribute_value_filter_existing: Migration…

ba37cd6

… to v13

[FIX] website_sale_product_attribute_value_filter_existing: developme…

9e6ec9b

…nt_status

Added translation using Weblate (Spanish)

65cfcc9

Added translation using Weblate (Catalan)

37993a5

Added translation using Weblate (Dutch)

76a9da3

[IMP] website_sale_product_attribute_value_filter_existing: black, is…

9c0bbc4

…ort, prettier

[MIG] website_sale_product_attribute_value_filter_existing: Migration…

1c52531

… to 14.0

[IMP] website_sale_product_attribute_value_filter_existing: black, is…

ca4cbfe

…ort, prettier

[MIG] website_sale_product_attribute_value_filter_existing: Migration…

e083f2f

… to 15.0 [UPD] Update website_sale_product_attribute_value_filter_existing.pot

[16.0][MIG] website_sale_product_attribute_value_filter_existing: Mig…

4042615

…ration to 16.0

[FIX] website_sale_product_attribute_value_filter_existing: match sig…

dc8a8d5

…nature match the function signature of shop with the original one from website_sale, to avoid potential issues with other modules overwriting the function and passing unexpected parameters

website_sale_product_attribute_value_filter_existing 16.0.1.0.1

c52425d

[FIX] website_sale_product_attribute_value_filter_existing: fix test …

193ad5b

…to check the real functionality of the module TT45590

[IMP] website_sale_product_attribute_value_filter_existing: test perf…

64327f3

…ormance improvement - Switch to setUpClass for avoiding repeat the same setup for each test. - Include context keys for avoiding mail operations overhead.

Added translation using Weblate (Italian)

e0343b0

[IMP] website_sale_product_attribute_value_filter_existing: adds filt…

f3584cd

…er extraction in mobile view

[IMP] website_sale_product_attribute_value_filter_existing: pre-commi…

cd38bcf

…t auto fixes

[MIG] website_sale_product_attribute_value_filter_existing: Migration…

decd2cb

… to 18.0 TT51372

[UPD] Update website_sale_product_attribute_value_filter_existing.pot

b06b45e

[BOT] post-merge updates

bada8ea

[FIX] website_sale_product_attribute_value_filter_existing: Hide attr…

695fe4d

…ibute container TT51372

[BOT] post-merge updates

6e5266e

Added translation using Weblate (Turkish)

4486451

Added translation using Weblate (Portuguese (Brazil))

340c902

[BOT] post-merge updates

033c5b4

Copilot AI review requested due to automatic review settings April 6, 2026 17:16

Copilot started reviewing on behalf of augusto-weiss April 6, 2026 17:16 View session

augusto-weiss force-pushed the 19.0-mig-website_sale_product_attribute_value_filter_existing-awe branch from 24a5b8f to 5721fd4 Compare April 6, 2026 17:19

Copilot AI reviewed Apr 6, 2026

View reviewed changes

[MIG] website_sale_product_attribute_value_filter_existing: Migration…

0a6e743

… to 19.0

augusto-weiss force-pushed the 19.0-mig-website_sale_product_attribute_value_filter_existing-awe branch from 5721fd4 to 0a6e743 Compare April 6, 2026 17:23

This was referenced Apr 6, 2026

[19.0][MIG] website_sale_product_attribute_value_filter_existing: Migration to 19.0 #1151

Open

Migration to version 19.0 #1115

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[19.0][MIG] website_sale_product_attribute_value_filter_existing#1193

[19.0][MIG] website_sale_product_attribute_value_filter_existing#1193
augusto-weiss wants to merge 30 commits intoOCA:19.0from
adhoc-dev:19.0-mig-website_sale_product_attribute_value_filter_existing-awe

augusto-weiss commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Copilot AI Apr 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants

		@@ -0,0 +1,18 @@
		import {registry} from "@web/core/registry";

		This module extends the functionality of website sale module to allow
		hide product attributes values which exist but not used on any variants.

Uh oh!

Conversation

augusto-weiss commented Apr 6, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 6, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

18 participants