[19.0][ADD] website_sale_partner_sale_contact#1233
Open
JasminSForgeFlow wants to merge 1 commit into
Open
Conversation
OCA-git-bot
added
series:19.0
mod:website_sale_partner_sale_contact
ivantodorovich
approved these changes
Jun 4, 2026
Comment on lines
+29
to
+30
| if self.parent_id != company: | ||
| self.parent_id = company |
Contributor
There was a problem hiding this comment.
This if-condition seems pointless. We've just created company so it's safe to assume it's not the contact's parent
Suggested change
| if self.parent_id != company: | |
| self.parent_id = company | |
| self.parent_id = company |
BhaveshHeliconia
approved these changes
Jun 8, 2026
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Tested locally functional review LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an order is placed from the website, the logged-in user is usually a
child contact of a company. Standard
website_salesets that contact as theorder customer (
partner_id).This module mirrors the backend
sale_partner_sale_contactbehaviour on thewebsite: the parent company becomes the order customer and the contact
is stored in the Sale Contact field (
sale_contact_partner_id). Billingand shipping addresses are left untouched.
Depends on:
@ForgeFlow