[18.0][ADD] website_sale_carrier_auto_assign: glue module to prevent duplic…#1248
Open
lef-adhoc wants to merge 1 commit into
Open
[18.0][ADD] website_sale_carrier_auto_assign: glue module to prevent duplic…#1248lef-adhoc wants to merge 1 commit into
lef-adhoc wants to merge 1 commit into
Conversation
…ate delivery lines When sale_order_carrier_auto_assign (OCA) is installed with carrier_on_create=True, its create/write overrides auto-create a delivery line from the shipping partner's property_delivery_carrier_id. On website orders, website_sale already handles carrier selection via _get_preferred_delivery_method + _set_delivery_method, so the OCA auto-assign runs in parallel and produces two delivery lines, causing: ValueError: Expected singleton: sale.order.line(N, M) in website_sale order_2_return_dict at checkout confirmation. This glue module overrides _is_auto_set_carrier_on_create to return False when website_id is set, so the OCA logic is skipped for e-commerce carts while backend orders continue to work normally.
OCA-git-bot
added
series:18.0
mod:website_sale_carrier_auto_assign
lef-adhoc
changed the title
ALopez-Adhoc
approved these changes
Jun 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ate delivery lines
When sale_order_carrier_auto_assign (OCA) is installed with carrier_on_create=True, its create/write overrides auto-create a delivery line from the shipping partner's property_delivery_carrier_id. On website orders, website_sale already handles carrier selection via _get_preferred_delivery_method + _set_delivery_method, so the OCA auto-assign runs in parallel and produces two delivery lines, causing:
ValueError: Expected singleton: sale.order.line(N, M)
in website_sale order_2_return_dict at checkout confirmation.
This glue module overrides _is_auto_set_carrier_on_create to return False when website_id is set, so the OCA logic is skipped for e-commerce carts while backend orders continue to work normally.