[18.0][MIG] hr_leave_custom_hour_interval: Migration to 18.0#182
Open
BhaveshHeliconia wants to merge 11 commits intoOCA:18.0from
Open
[18.0][MIG] hr_leave_custom_hour_interval: Migration to 18.0#182BhaveshHeliconia wants to merge 11 commits intoOCA:18.0from
BhaveshHeliconia wants to merge 11 commits intoOCA:18.0from
Conversation
|
Hi @BhaveshHeliconia, I encountered this error when trying to create a new leave on the UI: Can you check again? |
Kimkhoi3010
reviewed
May 29, 2025
|
|
||
| request_time_hour_from = fields.Float("Float hour from") | ||
|
|
||
| request_hour_from = fields.Char(compute="_compute_hour_from", store=True) |
There was a problem hiding this comment.
The fields request_hour_from and request_hour_to have been changed from Selection to Float — you can take a look at this commit
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_leave_custom_hour_interval
branch
from
beeb3b3 to
b8ec3ce
Compare
Contributor
Author
|
@Kimkhoi3010 : Please review again. Thanks. |
Can you check again? It doesn't work with me |
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_leave_custom_hour_interval
branch
from
b8ec3ce to
63e7c84
Compare
Contributor
Author
|
@Kimkhoi3010 : Please review again. Thanks. |
Kimkhoi3010
reviewed
Jun 4, 2025
| <field name="model">hr.leave</field> | ||
| <field name="inherit_id" ref="hr_holidays.hr_leave_view_form" /> | ||
| <field name="arch" type="xml"> | ||
| <field name="request_hour_from" position="attributes"> |
There was a problem hiding this comment.
Can you check the view again?
It's still not working with me.
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_leave_custom_hour_interval
branch
from
63e7c84 to
d2b3423
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
Bot
added
the
stale
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_leave_custom_hour_interval
branch
from
d2b3423 to
5c3bc35
Compare
Contributor
Author
|
Hey @OCA/human-resources-maintainers would be great if someone could have a look at this module. |
github-actions
Bot
removed
the
stale
[UPD] Update hr_leave_hour.pot [UPD] README.rst [ADD] icon.png
[UPD] Update hr_leave_custom_hour_interval.pot [UPD] README.rst
Currently translated at 100.0% (5 of 5 strings) Translation: hr-holidays-15.0/hr-holidays-15.0-hr_leave_custom_hour_interval Translate-URL: https://translation.odoo-community.org/projects/hr-holidays-15-0/hr-holidays-15-0-hr_leave_custom_hour_interval/it/
BhaveshHeliconia
force-pushed
the
18.0-mig-hr_leave_custom_hour_interval
branch
from
5c3bc35 to
aba982a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.