[17.0][ADD] hr_holidays_public_regional: New module hr_holidays_public_regional

[peluko00]

This module allows you to manage public regional holidays by defining them in dedicated calendars and assigning them to employees.
When enabled on a leave type, public regional holidays linked to the employee are automatically excluded from the leave duration calculation by default.

cc https://github.com/APSL 10205
@miquelalzanillas @javierobcn @mpascuall @BernatObrador @ppyczko @lbarry-apsl please review

[lbarry-apsl]

LGTM, code and runboat reviewed

[mpascuall]

LGTM!

[github-actions]

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

[peluko00]

Sorry for ping directly here @pedrobaeza , can you review please?

[pedrobaeza]

I don't find the need of this module, as you can put in the existing m2m in the public holiday lines the country states you need.

[peluko00]

I don't find the need of this module, as you can put in the existing m2m in the public holiday lines the country states you need.

For this reason, I made this module: to avoid depending on individual contacts when assigning a country state. This makes it easier to select a calendar.

[pedrobaeza]

You are not depending on individual contacts. Just fill the work address in the employee. It's the minimum to do...

[peluko00]

Even if an employee lives in one location, they might be assigned a public holiday calendar corresponding to a different geographical region (e.g., the location of their primary office or client) because the company's internal policy allows for such operational flexibility.

The module is designed specifically for this purpose. It enables the company to:

• Define separate regional holiday calendars (e.g., based on state, province, or country).

• Assign these specific regional calendars to individual employees, regardless of the address listed on their primary contact record.

This ensures that the employee's time-off management and working days are managed accurately according to the company's operational requirements rather than just their residential address.

[pedrobaeza]

The work address should be attached to the one having the rights and the obligations, not any free one. I see this module as redundant, but if others consider it useful, I won't block.

[peluko00]

What's your opinion @ivantodorovich ?

[ivantodorovich]

I'm not currently using neither features so I'm not informed enough to have an opinion, sorry

[peluko00]

Can we merge @pedrobaeza?

[peluko00]

Any update about this @pedrobaeza?

[pedrobaeza]

As said, I won't block, but don't agree either.

[peluko00]

This is already running in production and working as intended. Could you please merge it?

[pedrobaeza]

Yeah, you should find another PSC to merge it.

[peluko00]

@dreispt can you take a look please when you have time? Thanks in advance