[18.0][FIX] hr_holidays_leave_repeated: handle DST timezones#235
Open
remi-filament wants to merge 1 commit intoOCA:18.0from
Open
[18.0][FIX] hr_holidays_leave_repeated: handle DST timezones#235remi-filament wants to merge 1 commit intoOCA:18.0from
remi-filament wants to merge 1 commit intoOCA:18.0from
Conversation
Contributor
Author
|
Hi @hailangvn do you mind having a look at this PR ? |
julienCozo
approved these changes
Jan 5, 2026
Contributor
|
This PR has the |
Hugo-Trentesaux
approved these changes
Jan 5, 2026
hildickethan
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this fix, when using a timezone with DST and trying to repeat holidays over a period where DST changed (for instance if you want to repeat a holiday every friday over the full year), you would only get holidays before DST changed and after it was set back to original value.
This PR fixes that behaviour and adds corresponding tests (which were failing before the fix and solved afterwards)