Skip to content

[18.0][MIG] hr_leave_date_to_custom_hour: migration to 18.0#236

Open
quirino95 wants to merge 3 commits intoOCA:18.0from
PyTech-SRL:18.0-mig_hr_leave_date_to_custom_hour
Open

[18.0][MIG] hr_leave_date_to_custom_hour: migration to 18.0#236
quirino95 wants to merge 3 commits intoOCA:18.0from
PyTech-SRL:18.0-mig_hr_leave_date_to_custom_hour

Conversation

@quirino95
Copy link
Copy Markdown

@quirino95 quirino95 commented Dec 23, 2025

Migration of #188 to 18.0

@CRogos
Copy link
Copy Markdown

CRogos commented Dec 23, 2025

@quirino95 you need to preserve the commit history.
See the migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

@quirino95 quirino95 changed the title [MIG] hr_leave_date_to_custom_hour: migration to 18.0 [18.0][MIG] hr_leave_date_to_custom_hour: migration to 18.0 Dec 23, 2025
@quirino95 quirino95 force-pushed the 18.0-mig_hr_leave_date_to_custom_hour branch from a174025 to 64e4006 Compare December 23, 2025 14:46
SirPyTech
SirPyTech suggested changes Dec 24, 2025
View reviewed changes
Copy link
Copy Markdown

@SirPyTech SirPyTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chore:

@quirino95 you need to preserve the commit history.
See the migration guide: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-19.0

(from #236 (comment))

@quirino95 quirino95 force-pushed the 18.0-mig_hr_leave_date_to_custom_hour branch from 64e4006 to 90ff23a Compare December 29, 2025 14:22
@quirino95
Copy link
Copy Markdown
Author

quirino95 commented Dec 29, 2025

Hi @CRogos @SirPyTech,
Commit history has been updated, thank you!

SirPyTech
SirPyTech suggested changes Jan 7, 2026
View reviewed changes
Comment thread hr_leave_date_to_custom_hour/models/hr_leave.py Outdated
Comment thread hr_leave_date_to_custom_hour/tests/test_hr_leave.py Outdated
Comment thread hr_leave_date_to_custom_hour/views/hr_leave_views.xml Outdated
@quirino95 quirino95 force-pushed the 18.0-mig_hr_leave_date_to_custom_hour branch from 90ff23a to eb2b493 Compare January 8, 2026 15:25
SirPyTech
SirPyTech approved these changes Jan 12, 2026
View reviewed changes
Copy link
Copy Markdown

@SirPyTech SirPyTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and functional review, looks good 👍

Comment thread hr_leave_date_to_custom_hour/models/hr_leave.py Outdated
Comment thread hr_leave_date_to_custom_hour/tests/test_hr_leave.py Outdated
Comment thread hr_leave_date_to_custom_hour/views/hr_leave_views.xml Outdated
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Jan 12, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@anajuaristi
Copy link
Copy Markdown

anajuaristi commented Mar 30, 2026

Hi @CRogos @SirPyTech, any update on this?
Could it be merged, please?
Thank you!

@SirPyTech
Copy link
Copy Markdown

SirPyTech commented Mar 30, 2026

Hi @CRogos @SirPyTech, any update on this? Could it be merged, please? Thank you!

I don't have merge permission, please mention the appropriate OCA team: you can find it in https://oca.github.io/repo-maintainer-conf/.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@khanhratdeptrai khanhratdeptrai khanhratdeptrai approved these changes

@SirPyTech SirPyTech SirPyTech approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved ready to merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@quirino95 @CRogos @OCA-git-bot @anajuaristi @SirPyTech @khanhratdeptrai