Skip to content

[18.0][ADD] hr_holidays_leave_report_calendar_type#245

Merged
OCA-git-bot merged 1 commit intoOCA:18.0from
solvosci:18.0-add-hr_holidays_leave_report_calendar_type
Apr 13, 2026
Merged

[18.0][ADD] hr_holidays_leave_report_calendar_type#245
OCA-git-bot merged 1 commit intoOCA:18.0from
solvosci:18.0-add-hr_holidays_leave_report_calendar_type

Conversation

@dalonsod
Copy link
Copy Markdown
Contributor

@dalonsod dalonsod commented Apr 2, 2026

By default, general calendar view for leaves ("Overview") has no leave type filter.

This addon simply adds it to right filter panel, and at search bar as well.

imagen

@dalonsod
Copy link
Copy Markdown
Contributor Author

dalonsod commented Apr 2, 2026

@rrebollo @bizzappdev could you review? Thanks!

rrebollo
rrebollo approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown

@rrebollo rrebollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review. LGTM!

flotho
flotho approved these changes Apr 8, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

successfully tested on runboat.
LGTM
Thanks

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 8, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@cgarcia-solvos cgarcia-solvos mentioned this pull request Apr 9, 2026
Open
IriaAlonso
IriaAlonso reviewed Apr 9, 2026
View reviewed changes
Copy link
Copy Markdown

@IriaAlonso IriaAlonso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only minor comment

IriaAlonso
IriaAlonso reviewed Apr 10, 2026
View reviewed changes
Comment thread hr_holidays_leave_report_calendar_type/__init__.py Outdated
DantePereyra
DantePereyra reviewed Apr 10, 2026
View reviewed changes
Comment thread hr_holidays_leave_report_calendar_type/views/hr_leave_type.xml Outdated
cgarcia-solvos
cgarcia-solvos reviewed Apr 10, 2026
View reviewed changes
Comment thread hr_holidays_leave_report_calendar_type/views/hr_leave_type.xml Outdated
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 10, 2026

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@dalonsod dalonsod force-pushed the 18.0-add-hr_holidays_leave_report_calendar_type branch from 51bb739 to 0c9bac0 Compare April 10, 2026 12:09
@dalonsod
[ADD] hr_holidays_leave_report_calendar_type
02a2513 
By default, general calendar view for leaves ("Overview") has no leave type filter.

This addon simply adds it to right filter panel, and at search bar as well.
@dalonsod dalonsod force-pushed the 18.0-add-hr_holidays_leave_report_calendar_type branch from 0c9bac0 to 02a2513 Compare April 13, 2026 08:01
@dalonsod
Copy link
Copy Markdown
Contributor Author

dalonsod commented Apr 13, 2026

@pedrobaeza is this ready to be merged? Thanks!

@pedrobaeza pedrobaeza added this to the 18.0 milestone Apr 13, 2026
@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented Apr 13, 2026

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 13, 2026

What a great day to merge this nice PR. Let's do it!
Prepared branch 18.0-ocabot-merge-pr-245-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit a0fdc06 into OCA:18.0 Apr 13, 2026
7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented Apr 13, 2026

Congratulations, your PR was merged at 97fe169. Thanks a lot for contributing to OCA. ❤️

@cgarcia-solvos cgarcia-solvos mentioned this pull request Apr 15, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

5 more reviewers

@DantePereyra DantePereyra DantePereyra left review comments

@IriaAlonso IriaAlonso IriaAlonso left review comments

@flotho flotho flotho approved these changes

@rrebollo rrebollo rrebollo approved these changes

@cgarcia-solvos cgarcia-solvos cgarcia-solvos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved merged 🎉 ready to merge

Projects

None yet

Milestone

18.0

Development

Successfully merging this pull request may close these issues.

8 participants

@dalonsod @OCA-git-bot @pedrobaeza @flotho @rrebollo @DantePereyra @IriaAlonso @cgarcia-solvos