[17.0][FIX] intrastat_product: Use Odoo's VAT validation instead of stdnum.vatin.is_valid#309
Merged
OCA-git-bot merged 1 commit intoOCA:17.0from Jul 4, 2025
Conversation
pedrobaeza
reviewed
Jul 3, 2025
AndreuOForgeFlow
force-pushed
the
17.0-fix-intrastat_product-no_longer_use_stdnum.vatin_library
branch
from
b256b27 to
ca7605f
Compare
… and use Odoo's validation
AndreuOForgeFlow
force-pushed
the
17.0-fix-intrastat_product-no_longer_use_stdnum.vatin_library
branch
from
ca7605f to
4379884
Compare
pedrobaeza
approved these changes
Jul 3, 2025
GuillemCForgeFlow
approved these changes
Jul 4, 2025
Contributor
GuillemCForgeFlow
left a comment
GuillemCForgeFlow
left a comment
There was a problem hiding this comment.
makes sense 👍🏿
Member
|
Please fw-port it to 18: /ocabot merge patch |
Contributor
|
Hey, thanks for contributing! Proceeding to merge this for you. |
Contributor
|
Congratulations, your PR was merged at 86ea03b. Thanks a lot for contributing to OCA. ❤️ |
AndreuOForgeFlow
deleted the
17.0-fix-intrastat_product-no_longer_use_stdnum.vatin_library
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the use of
is_validfrom thestdnum.vatinlibrary with Odoo's validation logic in the VAT constraint check.The
stdnum.vatin.is_valid()function expects VAT numbers to be in international format, i.e., prefixed with the country code (e.g.,ESB66676008), and will return False if the VAT is not prefixed. In contrast, the validation that's used in Odoo (https://github.com/odoo/odoo/blob/211629b232861b960f6650f980d1e3b6acac94d9/addons/base_vat/models/res_partner.py#L184) supports local VAT numbers (e.g.,B66676008) without requiring the country prefix, because it combines the VAT value with the partner'scountry_id.