Skip to content

[16.0][FIX] intrastat_product: set the correct country code for Greece#321

Merged
OCA-git-bot merged 1 commit intoOCA:16.0from
factorlibre:16.0_intrastat_product_fix_country_code_for_greece
Nov 4, 2025
Merged

[16.0][FIX] intrastat_product: set the correct country code for Greece#321
OCA-git-bot merged 1 commit intoOCA:16.0from
factorlibre:16.0_intrastat_product_fix_country_code_for_greece

Conversation

@almumu
Copy link
Copy Markdown
Member

@almumu almumu commented Oct 30, 2025

Check correct country code for Greece. The correct is EL instead of GR.

Comment thread intrastat_product/models/intrastat_product_declaration.py Outdated
Comment thread intrastat_product/models/intrastat_product_declaration.py Outdated
@almumu almumu force-pushed the 16.0_intrastat_product_fix_country_code_for_greece branch 2 times, most recently from 0dca3b1 to bba08ad Compare October 31, 2025 06:40
Check correct country code for Greece. The correct is EL instead of GR.
@almumu almumu force-pushed the 16.0_intrastat_product_fix_country_code_for_greece branch from 9b10348 to bf9ff14 Compare October 31, 2025 06:46
Copy link
Copy Markdown
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although perhaps only one mapping could be defined, the change is consistent.

@almumu almumu marked this pull request as ready for review November 4, 2025 15:01
Copy link
Copy Markdown
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-321-by-pedrobaeza-bump-patch, awaiting test results.

@pedrobaeza
Copy link
Copy Markdown
Member

Please fw-port it to upper versions.

@OCA-git-bot OCA-git-bot merged commit 72db5e6 into OCA:16.0 Nov 4, 2025
6 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at cabb02d. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza
Copy link
Copy Markdown
Member

@almumu are you going to fw-port the changes?

@almumu
Copy link
Copy Markdown
Member Author

almumu commented Nov 11, 2025

@pedrobaeza fw-port done to v17, the tests were not passing with a simple cherry pick,so i have adapted it for v17. Maybe when #324 is merged i can do a direct fwport with a cherry-pick from v17 to v18.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants