Skip to content

[17.0][MIG] datev_export_xml: Migration to 17.0#174

Merged
OCA-git-bot merged 18 commits intoOCA:17.0from
Tecnativa:17.0-mig-datev_export_xml
May 20, 2025
Merged

[17.0][MIG] datev_export_xml: Migration to 17.0#174
OCA-git-bot merged 18 commits intoOCA:17.0from
Tecnativa:17.0-mig-datev_export_xml

Conversation

@victoralmau
Copy link
Copy Markdown
Member

@victoralmau victoralmau commented Feb 19, 2025 •
edited by pedrobaeza
Loading

Migration to 17.0

Locked by:

@Tecnativa TT54915

@victoralmau victoralmau force-pushed the 17.0-mig-datev_export_xml branch from 145c24a to 2b8bc39 Compare February 19, 2025 12:47
@victoralmau victoralmau mentioned this pull request Feb 20, 2025
Open
5 tasks
@david-fleischmann
Copy link
Copy Markdown

david-fleischmann commented Apr 4, 2025

@victoralmau
image
Something is not correct yet in that version. I'm unable to see errors in the xml export to fix them. In v14 there was a Validate button where I had a clear overview of the erros in the accoun.move records:
image

@david-fleischmann
Copy link
Copy Markdown

david-fleischmann commented Apr 6, 2025 •
edited
Loading

@victoralmau @fkantelberg
Just found that the display of the exception_info seems not to work as in V16 (runbot):
image

In V17 the rendering of the error message seems to fail:
image

@victoralmau victoralmau mentioned this pull request Apr 22, 2025
Merged
@victoralmau
Copy link
Copy Markdown
Member Author

victoralmau commented Apr 22, 2025

@victoralmau image Something is not correct yet in that version. I'm unable to see errors in the xml export to fix them. In v14 there was a Validate button where I had a clear overview of the erros in the accoun.move records: image

You are right, actually this was added in v15 but not in v16, therefore, I have added it first in v16 #179 and when it is merged, I will add it here.

IMO the comment #174 (comment) is related to the other change.

@victoralmau victoralmau force-pushed the 17.0-mig-datev_export_xml branch 2 times, most recently from f1414b3 to 64a8ae2 Compare May 7, 2025 09:00
@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented May 7, 2025

/ocabot migration datev_export_xml

Please remove the temporary commit.

@OCA-git-bot OCA-git-bot added this to the 17.0 milestone May 7, 2025
fkantelberg and others added 17 commits May 7, 2025 11:42
@fkantelberg @victoralmau
datev_export_xml: Add module to export account.move as DATEV XML
36454b8
@fkantelberg @victoralmau
Move out common configurations to base module
dae86a0 
Update datev_export_xml.pot

README.rst

icon.png

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-germany-14.0/l10n-germany-14.0-datev_export_xml
Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-14-0/l10n-germany-14-0-datev_export_xml/
@fkantelberg @victoralmau
[MIG] datev_export_xml: Migration to 15.0
7bc7ab2
@fkantelberg @victoralmau
[FIX] datev_export_xml: Fix call of sorted for pickings
958fbff
@fkantelberg @victoralmau
[FIX] datev_export_xml: Enforce some limits and use different field f…
b0eaba8 
…or tax amount
@fkantelberg @victoralmau
[IMP] datev_export_xml: Check invoices before rendering to prevent ba…
dc300f1 
…dly described exceptions
@fkantelberg @victoralmau
[FIX] datev_export_xml: Negate values for refunds (invoice corrections)
23f1fee
@fkantelberg @victoralmau
[FIX] Problem when tax_base_amount is 0 or line names fallback to False
0a53fe2
@fkantelberg @victoralmau
[FIX] datev_export_xml: Skip non-product lines
ad2fd6d 
[UPD] Update datev_export_xml.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-germany-15.0/l10n-germany-15.0-datev_export_xml
Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-15-0/l10n-germany-15-0-datev_export_xml/
@victoralmau
[IMP] : pre-commit stuff
d68cce0
@victoralmau
[MIG] : Migration datev_export_xml to 16.0
9728980
@victoralmau
[IMP] datev_export_xml: Update template invoice_party account
38a00d2
@victoralmau
[FIX] datev_export_xml: display smart buttons
368370b 
[UPD] Update datev_export_xml.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-germany-16.0/l10n-germany-16.0-datev_export_xml
Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-16-0/l10n-germany-16-0-datev_export_xml/
@fkantelberg @victoralmau
[IMP] datev_export_xml: Allow previous validation to see all errors o…
77125f4 
…n invoices. Fix some edge cases like fully discounted lines
@fkantelberg @victoralmau
[FIX] datev_export_xml: Add general check on invoice e.g. when multip…
071dabe 
…le taxes exists
@victoralmau
[FIX] datev_export_xml: Fix tests (create journals if they do not exist)
0a4ef7b 
[UPD] Update datev_export_xml.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-germany-16.0/l10n-germany-16.0-datev_export_xml
Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-16-0/l10n-germany-16-0-datev_export_xml/
@victoralmau
[IMP] datev_export_xml: pre-commit auto fixes
f0a2c40
@victoralmau victoralmau force-pushed the 17.0-mig-datev_export_xml branch from 64a8ae2 to 1d819d5 Compare May 7, 2025 09:42
etobella
etobella reviewed May 7, 2025
View reviewed changes
@victoralmau victoralmau force-pushed the 17.0-mig-datev_export_xml branch from 1d819d5 to 58eabd8 Compare May 7, 2025 11:47
@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented May 19, 2025

@etobella @david-fleischmann is this OK for you then?

etobella
etobella approved these changes May 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pedrobaeza
Copy link
Copy Markdown
Member

pedrobaeza commented May 20, 2025

/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 20, 2025

On my way to merge this fine PR!
Prepared branch 17.0-ocabot-merge-pr-174-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 13a745d into OCA:17.0 May 20, 2025
5 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

OCA-git-bot commented May 20, 2025

Congratulations, your PR was merged at cf0c7bc. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza deleted the 17.0-mig-datev_export_xml branch May 20, 2025 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@etobella etobella etobella approved these changes

Assignees

No one assigned

Labels

approved merged 🎉

Projects

None yet

Milestone

17.0

Development

Successfully merging this pull request may close these issues.

6 participants

@victoralmau @david-fleischmann @pedrobaeza @OCA-git-bot @etobella @fkantelberg