Skip to content

[19.0][MIG] datev_import_csv_dtvf: Migration to 19.0#209

Open
lnol wants to merge 33 commits intoOCA:19.0from
lnol:19.0-mig-datev_import_csv_dtvf
Open

[19.0][MIG] datev_import_csv_dtvf: Migration to 19.0#209
lnol wants to merge 33 commits intoOCA:19.0from
lnol:19.0-mig-datev_import_csv_dtvf

Conversation

@lnol
Copy link
Copy Markdown

@lnol lnol commented Dec 29, 2025

No description provided.

hbrunn and others added 30 commits December 29, 2025 15:31
description (covered use cases, limitations, usage)
Fix for the automatic test
account.menu_finance_entries_actions was renamed to
account.menu_finance_entries
account.company_id is now many2many company_ids
search must be adapted for this change
* we fix the tests by requiring l10n_de for account-setup
@lnol lnol marked this pull request as draft December 29, 2025 15:45
@lnol lnol marked this pull request as ready for review December 29, 2025 16:14
@lnol lnol force-pushed the 19.0-mig-datev_import_csv_dtvf branch from fe3d2a4 to 69eb111 Compare December 29, 2025 18:33
@lnol
Copy link
Copy Markdown
Author

lnol commented Dec 29, 2025

  • The module follows Odoo best practices for translations by interpolating strings only after translation (pattern looks like this self.env._("… %(name)s …") % {"name": value}))
  • pylint-odoo flags this usage with a 'translation-not-lazy' rule. Due to a lack of lazy-args for _(), this could be considered a stylistic false positive for Odoo’s i18n pattern.
  • To keep the translator-friendly implementation and also pass the test, I followed the suggested solution from here and added precise one-line disables on the relevant translation lines

@lnol lnol mentioned this pull request Dec 29, 2025
3 tasks
@smaddlsoft
Copy link
Copy Markdown

thanks @lnol for your contributions here. Maybe the German OCA communitys code sprint in April could be interesting for you as well to streamline and improve our l10n_de collaborations: https://odoo-community.org/event/spring-sprint-hamburg-2026-04-23-2026-04-24-213/register

@pniederlag
Copy link
Copy Markdown
Member

I have tested the module briefly in an installation. From my point of view it's ready to be merged. +1 by reading and +1 by testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants