[19.0][MIG] l10n_din5008_move_name: Migration to 19.0#212
[19.0][MIG] l10n_din5008_move_name: Migration to 19.0#212OCA-git-bot merged 4 commits intoOCA:19.0from
Conversation
mt-software-de
force-pushed
the
19.0-mig-l10n_din5008_move_name_new
branch
from
4ecf591 to
f418f79
Compare
|
@etobella @tv-openbig maybe you can review this PR. |
mt-software-de
force-pushed
the
19.0-mig-l10n_din5008_move_name_new
branch
from
f418f79 to
343b667
Compare
|
The problem is that with the current change, it is no longer this way... it has probably a span inside 🤔 |
mt-software-de
force-pushed
the
19.0-mig-l10n_din5008_move_name_new
branch
from
343b667 to
5ebb27a
Compare
Yes. :-) |
|
@etobella i would need the addon also now for v18. Whats your recommendation? |
| inherit_id="l10n_din5008.report_invoice_document" | ||
| priority="100" | ||
| > | ||
| <xpath expr="//t[@t-set='din5008_document_title']/span" position="after"> |
There was a problem hiding this comment.
If you prefer direct reference.
| <xpath expr="//t[@t-set='din5008_document_title']/span" position="after"> | |
| <xpath expr='//span[@t-if="o and o._name == 'account.move'"]' position="after"> |
There was a problem hiding this comment.
IMO. din5008_document_title should/must be in the xpath.
Its much more readable and explicit.
If you insist on it. I would change it to.
<xpath expr='//t[@t-set='din5008_document_title']//span[@t-if="o and o._name == 'account.move'"]' position="after">
mt-software-de
force-pushed
the
19.0-mig-l10n_din5008_move_name_new
branch
2 times, most recently
from
0b321b0 to
f3c87fd
Compare
mt-software-de
force-pushed
the
19.0-mig-l10n_din5008_move_name_new
branch
from
f3c87fd to
96f383e
Compare
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
/ocabot migration l10n_din5008_move_name |
|
Congratulations, your PR was merged at d4b67cb. Thanks a lot for contributing to OCA. ❤️ |
4 participants
Since the field
l10n_din5008_document_titleofaccount.movewas removed and moved into the template.I removed the models and added the template.