Skip to content

[18.0][MIG] datev_export_xml#217

Merged
OCA-git-bot merged 35 commits intoOCA:18.0from
hbrunn:18.0-mig-datev_export_xml
Mar 18, 2026
Merged

[18.0][MIG] datev_export_xml#217
OCA-git-bot merged 35 commits intoOCA:18.0from
hbrunn:18.0-mig-datev_export_xml

Conversation

@hbrunn
Copy link
Copy Markdown
Member

@hbrunn hbrunn commented Jan 26, 2026

contains #160

fkantelberg and others added 23 commits January 26, 2026 05:27
Update datev_export_xml.pot

README.rst

icon.png

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-germany-14.0/l10n-germany-14.0-datev_export_xml
Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-14-0/l10n-germany-14-0-datev_export_xml/
[UPD] Update datev_export_xml.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-germany-15.0/l10n-germany-15.0-datev_export_xml
Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-15-0/l10n-germany-15-0-datev_export_xml/
[UPD] Update datev_export_xml.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-germany-16.0/l10n-germany-16.0-datev_export_xml
Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-16-0/l10n-germany-16-0-datev_export_xml/
…n invoices. Fix some edge cases like fully discounted lines
[UPD] Update datev_export_xml.pot

[BOT] post-merge updates

Update translation files

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: l10n-germany-16.0/l10n-germany-16.0-datev_export_xml
Translate-URL: https://translation.odoo-community.org/projects/l10n-germany-16-0/l10n-germany-16-0-datev_export_xml/
@hbrunn
Copy link
Copy Markdown
Member Author

hbrunn commented Jan 26, 2026

/ocabot migration datev_export_xml

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Jan 26, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 26, 2026
3 tasks
@hbrunn hbrunn force-pushed the 18.0-mig-datev_export_xml branch 2 times, most recently from 518e2e5 to 081553e Compare January 26, 2026 17:01
Copy link
Copy Markdown
Contributor

@mt-software-de mt-software-de left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx. For the migration.
Code Review only. LGTM.
Could you squash 7e24bb7 into 60c2ff3 ?

@hbrunn
Copy link
Copy Markdown
Member Author

hbrunn commented Jan 28, 2026

Could you squash 7e24bb7 into 60c2ff3 ?

I'd rather not. This commit was done by another person, so this would destroy attribution. And the feature is simpler to backport if I keep it as separate commit

@mt-software-de
Copy link
Copy Markdown
Contributor

mt-software-de commented Jan 28, 2026

Could you squash 7e24bb7 into 60c2ff3 ?

I'd rather not. This commit was done by another person, so this would destroy attribution. And the feature is simpler to backport if I keep it as separate commit

I haven't found it on any existing branch so i thought it belongs to the migration.
Is it cherry-picked from an existing oca branch, if not could you reword the commit message?
[IMP] datev_export_xml: ...

@hbrunn hbrunn force-pushed the 18.0-mig-datev_export_xml branch from 081553e to bec68a9 Compare January 28, 2026 09:37
@hbrunn
Copy link
Copy Markdown
Member Author

hbrunn commented Jan 28, 2026

changed the commit message

@jans23
Copy link
Copy Markdown
Contributor

jans23 commented Jan 29, 2026

Tested and works well for me.

@ivs-cetmix
Copy link
Copy Markdown
Member

Hey @hbrunn thank you for your contribution! Would be great if you could improve the test coverage in a separate commit so we could have it merged.

@hbrunn
Copy link
Copy Markdown
Member Author

hbrunn commented Feb 6, 2026

like in bec68a9?

@ivs-cetmix
Copy link
Copy Markdown
Member

like in bec68a9?

A sort of. We need to have more tests so the Codecov check could pass.

@OSevangelist
Copy link
Copy Markdown

@hbrunn @jans23 @ivs-cetmix what is the status here. Can we merge it?

@OSevangelist
Copy link
Copy Markdown

@hbrunn @ivs-cetmix i don't know but just increasing the test coverage for sake of improving the computed coverage is pointless. Afaik there is now such policy that would effectively hinder from merging here or am i wrong

@ivs-cetmix
Copy link
Copy Markdown
Member

@OSevangelist I'm just following the migration Wiki guidelines https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-18.0
However I agree with you that not having 0.000something test coverage wouldn't heart anyone.
With this said
/ocabot merge nobump

@OCA-git-bot
Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-217-by-ivs-cetmix-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 5a3931a into OCA:18.0 Mar 18, 2026
5 of 7 checks passed
@OCA-git-bot
Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 8f467aa. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants