[17.0][ADD] l10n_es_atc_sii_oca: New module - #4203
Merged
Merged
Conversation
sergio-teruel
force-pushed
the
17.0-ADD-l10n_es_atc_sii_oca
branch
from
May 19, 2025 21:03
c4d7001 to
7c3b8f6
Compare
|
Hola @sergio-teruel @Christian-RB @pedrobaeza precisamente estoy revisando el PR #4097 y echaba en falta el mapeo de los impuestos del IGIC para el SII. Al igual que tenemos en donde se referencian los impuestos para el DUA.Entiendo que en este módulo se añade la parte del DUA a nivel de registro SII con el tipo de factura F5 y en el otro l10n_es_igic aplicará la lógica contable. ¿? |
sergio-teruel
force-pushed
the
17.0-ADD-l10n_es_atc_sii_oca
branch
from
September 18, 2025 00:28
a343cdc to
d4c9677
Compare
Member
|
@sergio-teruel esto está ya listo? |
sergio-teruel
force-pushed
the
17.0-ADD-l10n_es_atc_sii_oca
branch
from
January 9, 2026 06:10
2ea7a47 to
a77c606
Compare
pedrobaeza
force-pushed
the
17.0-ADD-l10n_es_atc_sii_oca
branch
from
January 12, 2026 18:42
a77c606 to
4b700ef
Compare
sergio-teruel
marked this pull request as ready for review
January 13, 2026 16:58
carlosdauden
approved these changes
Jan 13, 2026
…xists in SII atc TT60254
sergio-teruel
force-pushed
the
17.0-ADD-l10n_es_atc_sii_oca
branch
from
February 24, 2026 13:52
1359adf to
95e1464
Compare
Contributor
Author
|
This PR is ready for merge... |
christian-ramos-tecnativa
approved these changes
Feb 24, 2026
christian-ramos-tecnativa
left a comment
christian-ramos-tecnativa
left a comment
Contributor
There was a problem hiding this comment.
Lo veo bien
carlos-lopez-tecnativa
approved these changes
Feb 24, 2026
carlos-lopez-tecnativa
left a comment
carlos-lopez-tecnativa
left a comment
Contributor
There was a problem hiding this comment.
Code review, solo un comentario no bloqueante.
¿Los commits se pueden unificar, al ser todos de un mismo módulo nuevo?
Comment on lines
+50
to
+71
| def _get_aeat_invoice_dict_out(self, cancel=False): | ||
| inv_dict = super()._get_aeat_invoice_dict_out(cancel=cancel) | ||
| if self._get_sii_tax_agency() == self.env.ref( | ||
| "l10n_es_aeat.aeat_tax_agency_canarias" | ||
| ): | ||
| inv_dict = self._sii_atc_replace_tax_keys(inv_dict) | ||
| return inv_dict | ||
|
|
||
| def _get_aeat_invoice_dict_in(self, cancel=False): | ||
| inv_dict = super()._get_aeat_invoice_dict_in(cancel=cancel) | ||
| if self._get_sii_tax_agency() == self.env.ref( | ||
| "l10n_es_aeat.aeat_tax_agency_canarias" | ||
| ): | ||
| inv_dict = self._sii_atc_replace_tax_keys(inv_dict) | ||
| return inv_dict | ||
|
|
||
| def _get_sii_identifier(self): | ||
| if self._get_sii_tax_agency() == self.env.ref( | ||
| "l10n_es_aeat.aeat_tax_agency_canarias" | ||
| ): | ||
| self = self.with_context(is_canary_tax_agency=True) | ||
| return super()._get_sii_identifier() |
Contributor
There was a problem hiding this comment.
¿Por qué no crear un método que devuelva si es agencia canaria o no?
Suggested change
| def _get_aeat_invoice_dict_out(self, cancel=False): | |
| inv_dict = super()._get_aeat_invoice_dict_out(cancel=cancel) | |
| if self._get_sii_tax_agency() == self.env.ref( | |
| "l10n_es_aeat.aeat_tax_agency_canarias" | |
| ): | |
| inv_dict = self._sii_atc_replace_tax_keys(inv_dict) | |
| return inv_dict | |
| def _get_aeat_invoice_dict_in(self, cancel=False): | |
| inv_dict = super()._get_aeat_invoice_dict_in(cancel=cancel) | |
| if self._get_sii_tax_agency() == self.env.ref( | |
| "l10n_es_aeat.aeat_tax_agency_canarias" | |
| ): | |
| inv_dict = self._sii_atc_replace_tax_keys(inv_dict) | |
| return inv_dict | |
| def _get_sii_identifier(self): | |
| if self._get_sii_tax_agency() == self.env.ref( | |
| "l10n_es_aeat.aeat_tax_agency_canarias" | |
| ): | |
| self = self.with_context(is_canary_tax_agency=True) | |
| return super()._get_sii_identifier() | |
| def _is_canarias_sii_tax_agency(self): | |
| return self._get_sii_tax_agency() == self.env.ref( | |
| "l10n_es_aeat.aeat_tax_agency_canarias" | |
| ) | |
| def _get_aeat_invoice_dict_out(self, cancel=False): | |
| inv_dict = super()._get_aeat_invoice_dict_out(cancel=cancel) | |
| if self._is_canarias_sii_tax_agency(): | |
| inv_dict = self._sii_atc_replace_tax_keys(inv_dict) | |
| return inv_dict | |
| def _get_aeat_invoice_dict_in(self, cancel=False): | |
| inv_dict = super()._get_aeat_invoice_dict_in(cancel=cancel) | |
| if self._is_canarias_sii_tax_agency(): | |
| inv_dict = self._sii_atc_replace_tax_keys(inv_dict) | |
| return inv_dict | |
| def _get_sii_identifier(self): | |
| if self._is_canarias_sii_tax_agency(): | |
| self = self.with_context(is_canary_tax_agency=True) | |
| return super()._get_sii_identifier() |
Member
|
/ocabot merge nobump |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at 180d16c. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @Tecnativa
ping @carlosdauden @carlos-lopez-tecnativa @syci @christian-ramos-tecnativa