Skip to content

[18.0][MIG] l10n_es_vat_book_pos: Migration to 18.0 - #4841

Merged
OCA-git-bot merged 2 commits into
OCA:18.0from
QubiQ:18.0-mig-l10n_es_vat_book_pos
Feb 20, 2026
Merged

[18.0][MIG] l10n_es_vat_book_pos: Migration to 18.0#4841
OCA-git-bot merged 2 commits into
OCA:18.0from
QubiQ:18.0-mig-l10n_es_vat_book_pos

Conversation

@polqubiq

Copy link
Copy Markdown
Contributor

Migration of l10n_es_vat_book_pos from 17.0 to 18.0.

@polqubiq

polqubiq commented Feb 19, 2026

Copy link
Copy Markdown
Contributor Author

@etobella I migrated the module you mentioned #3754 (comment)
I think the tests got stuck.
cc: @pedrobaeza

@polqubiq
polqubiq force-pushed the 18.0-mig-l10n_es_vat_book_pos branch 2 times, most recently from 26943f7 to 9285de0 Compare February 19, 2026 11:11
@pedrobaeza

Copy link
Copy Markdown
Member

Es cierto que hay un problema con la librería odoo_test_helper que emite unos logs molestos:

OCA/odoo-test-helper#39

Pero el error del CI es de este módulo:

2026-02-19 11:22:30,885 3232 ERROR odoo odoo.addons.l10n_es_vat_book_pos.tests.test_vat_book_pos: ERROR: TestVATBookPOS.test_vat_book_pos
Traceback (most recent call last):
  File "/opt/odoo/odoo/models.py", line 6274, in ensure_one
    _id, = self._ids
ValueError: not enough values to unpack (expected 1, got 0)

During handling of the above exception, another exception occurred:

Traceback (most recent call last):
  File "/__w/l10n-spain/l10n-spain/l10n_es_vat_book_pos/tests/test_vat_book_pos.py", line 68, in test_vat_book_pos
    session = self._create_session()
  File "/__w/l10n-spain/l10n-spain/l10n_es_vat_book_pos/tests/test_vat_book_pos.py", line 21, in _create_session
    self.config.open_ui()
  File "/opt/odoo/addons/point_of_sale/models/pos_config.py", line 711, in open_ui
    self.ensure_one()
  File "/opt/odoo/odoo/models.py", line 6277, in ensure_one
    raise ValueError("Expected singleton: %s" % self)
ValueError: Expected singleton: pos.config()

@HaraldPanten

Copy link
Copy Markdown
Contributor

/ocabot migration l10n_es_vat_book_pos

@OCA-git-bot OCA-git-bot added this to the 18.0 milestone Feb 20, 2026
@OCA-git-bot OCA-git-bot mentioned this pull request Feb 20, 2026
67 tasks
@polqubiq
polqubiq force-pushed the 18.0-mig-l10n_es_vat_book_pos branch from 9285de0 to f860fe3 Compare February 20, 2026 10:32
@polqubiq

polqubiq commented Feb 20, 2026

Copy link
Copy Markdown
Contributor Author

@pedrobaeza ahora los tests están en estado cancelado.
De todas formas, he hecho modificaciones en los tests. Ahora deberían estar bien (como mínimo, han pasado correctamente en mi local).
Gracias.

@pedrobaeza

Copy link
Copy Markdown
Member

@polqubiq haz por favor rebase sobre lo último de la rama, que el otro error está ya corregido.

@polqubiq
polqubiq force-pushed the 18.0-mig-l10n_es_vat_book_pos branch from f860fe3 to 5f93e5a Compare February 20, 2026 14:14
@polqubiq

Copy link
Copy Markdown
Contributor Author

@polqubiq haz por favor rebase sobre lo último de la rama, que el otro error está ya corregido.

@pedrobaeza ¡hecho! Sale otro error en el test pero no es de código. Es de Remote end closed connection without response.

@pedrobaeza pedrobaeza left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 18.0-ocabot-merge-pr-4841-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Feb 20, 2026
Signed-off-by pedrobaeza
@OCA-git-bot

Copy link
Copy Markdown
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 18.0-ocabot-merge-pr-4841-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza

Copy link
Copy Markdown
Member

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-4841-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 712541c into OCA:18.0 Feb 20, 2026
6 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 601f602. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants