Skip to content

[18.0][ADD] l10n_es_hr_collective_agreement - #4855

Merged
OCA-git-bot merged 1 commit into
OCA:18.0from
sygel-technology:18.0-add-l10n_es_hr_collective_agreement
Feb 26, 2026
Merged

[18.0][ADD] l10n_es_hr_collective_agreement#4855
OCA-git-bot merged 1 commit into
OCA:18.0from
sygel-technology:18.0-add-l10n_es_hr_collective_agreement

Conversation

@Anxo82

@Anxo82 Anxo82 commented Feb 24, 2026

Copy link
Copy Markdown
Contributor

@HaraldPanten @Jaimermaccione

Adds a complementary module providing initial Spanish configuration data for collective agreements. Requires hr_collective_agreement.

  • [T-8786]

@Anxo82
Anxo82 marked this pull request as draft February 24, 2026 07:53
@HaraldPanten

Copy link
Copy Markdown
Contributor

@Anxo82 Puedes hacer el README en castellano, por favor? En la localización podemos gestionarlo así.

Gracias.

@Anxo82
Anxo82 force-pushed the 18.0-add-l10n_es_hr_collective_agreement branch from cd283f5 to abbd914 Compare February 24, 2026 12:28
@Anxo82

Anxo82 commented Feb 24, 2026

Copy link
Copy Markdown
Contributor Author

@HaraldPanten Ya he puesto en castellano el README.
Gracias

@Jaimermaccione Jaimermaccione left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anxo82 The module has been functionally tested in a local environment.

Installation is straightforward and does not require any additional configuration.
Once installed, it correctly creates the predefined Spanish master data needed for the Collective Agreement module, including:

  • Official publications (e.g. BOE, DOGC)
  • Agreement scopes (Autonomous, Provincial, etc.)

It behaves as expected and properly supports the Spanish regulatory setup for collective agreements.

LGTM 👍

Note (non-blocking)

If you already have records created with the same name in Agreement Scope or Official Publications, the installation will fail due to the unique constraint on the name field.

This is technically correct from a data integrity perspective, but it’s something to keep in mind.

@ValentinVinagre ValentinVinagre left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Anxo82
Anxo82 marked this pull request as ready for review February 26, 2026 10:19
@Anxo82

Anxo82 commented Feb 26, 2026

Copy link
Copy Markdown
Contributor Author

@HaraldPanten Could you please review it ?
Thanks

@HaraldPanten HaraldPanten left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-4855-by-HaraldPanten-bump-nobump, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit e710c36 into OCA:18.0 Feb 26, 2026
7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at ed93530. Thanks a lot for contributing to OCA. ❤️

@HaraldPanten
HaraldPanten deleted the 18.0-add-l10n_es_hr_collective_agreement branch February 26, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants