Skip to content

[18.0][ADD] l10n_es_pos_sii_match + [REF] l10n_es_aeat_sii_match - #4866

Merged
OCA-git-bot merged 2 commits into
OCA:18.0from
Tecnativa:18.0-add-l10n_es_pos_sii_match
May 8, 2026
Merged

[18.0][ADD] l10n_es_pos_sii_match + [REF] l10n_es_aeat_sii_match#4866
OCA-git-bot merged 2 commits into
OCA:18.0from
Tecnativa:18.0-add-l10n_es_pos_sii_match

Conversation

@pedrobaeza

@pedrobaeza pedrobaeza commented Feb 25, 2026

Copy link
Copy Markdown
Member

[ADD] l10n_es_pos_sii_match: Glue module for l10n_es_aeat_sii_match and l10n_es_pos_sii

It adds to the contrast the PoS orders.

[REF] l10n_es_aeat_sii_match: Generalize its usage

Moving the contents to the SII mixin and doing the required adaptations:

  • Don't browse, but keep Odoo recordset in variables.
  • Rename variables.
  • Adapt DB layout to contain a many2one reference for the specified model.
  • Refactor code.
  • Start to support other period types (trimesters).
  • Make it multi-record applicable.

With this work, we are also promoting to both co-author and maintainers.

@Tecnativa

@pedrobaeza pedrobaeza added this to the 18.0 milestone Feb 25, 2026
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Hi @Reyes4711-S73, @Abranes,
some modules you are maintaining are being modified, check this out!

@pedrobaeza
pedrobaeza force-pushed the 18.0-add-l10n_es_pos_sii_match branch 6 times, most recently from 54eb1e4 to 4f2ff87 Compare February 26, 2026 01:25

@Abranes Abranes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revisión de código

Comment thread l10n_es_aeat_sii_match/models/sii_mixin.py Outdated
@pedrobaeza
pedrobaeza force-pushed the 18.0-add-l10n_es_pos_sii_match branch 7 times, most recently from 1975d7d to 002c551 Compare February 27, 2026 02:21
@victoralmau
victoralmau force-pushed the 18.0-add-l10n_es_pos_sii_match branch from 002c551 to 479d53a Compare March 12, 2026 15:43
Moving the contents to the SII mixin and doing the required adaptations:

- Don't browse, but keep Odoo recordset in variables.
- Rename variables.
- Adapt DB layout to contain a many2one reference for the specified
  model.
- Start to support other period types (trimesters).
- Refactor code.
- Include a new method for building the match result dictionary, to
  avoid code duplication and encapsulate the logic in one place.
- Make it multi-record applicable.

With this work, we are also promoting to both co-author and maintainers.
@pedrobaeza
pedrobaeza force-pushed the 18.0-add-l10n_es_pos_sii_match branch from 479d53a to ba7e826 Compare May 8, 2026 11:06
@OCA-git-bot OCA-git-bot added series:18.0 mod:l10n_es_aeat_sii_match Module l10n_es_aeat_sii_match mod:l10n_es_pos_sii_match Module l10n_es_pos_sii_match labels May 8, 2026
…nd l10n_es_pos_sii

It adds to the contrast the PoS orders.
@pedrobaeza
pedrobaeza force-pushed the 18.0-add-l10n_es_pos_sii_match branch from ba7e826 to 88002a1 Compare May 8, 2026 11:07
@pedrobaeza

Copy link
Copy Markdown
Member Author

/ocabot merge major

@OCA-git-bot

Copy link
Copy Markdown
Contributor

On my way to merge this fine PR!
Prepared branch 18.0-ocabot-merge-pr-4866-by-pedrobaeza-bump-major, awaiting test results.

@OCA-git-bot
OCA-git-bot merged commit 6316f42 into OCA:18.0 May 8, 2026
5 of 7 checks passed
@OCA-git-bot

Copy link
Copy Markdown
Contributor

Congratulations, your PR was merged at 88274e4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants