[19.0 ][MIG] l10n_es_aeat_mod349 - #4911
Merged
Merged
Conversation
…c module for aeat models, 347 module was portedto v6.0 and adds new module to print AEAT model 349.
…ueñas mejoras generales (vistas, traducciones, código) y corrección pequeño bug por un olvido en la adaptación de la v5 a la v6
* Only use the first four digits of fiscal year's code to determine fiscal year's number and also give a decent message to the user if it's not a number instead of simply crashing. * Hacer opcional el campo Operation Key en las facturas, permitiendo que esté en blanco. * Ser un poco menos rigurosos con que el año esté en el código del año fiscal. Atención: deberíamos añadir un campo con este valor en lugar de hacer este hack.
* FIX: Corregimos una serie de errores que había en las rectificaciones a la hora de obtener las declaraciones originales, si había alguna que cumplía los requisitos pero sin pertenecer a un modelo. Quizás se solucionara mejor con un on_delete='cascade'. * RFR: Cambio de licencia de GPL3 a AGPL3 en el resto de módulos de localización española, con el consentimiento de todos los autores expresado vía lista de correo del equipo de localización openerp-spain@googlegroups.com
* Only use the first four digits of fiscal year's code to determine fiscal year's number and also give a decent message to the user if it's not a number instead of simply crashing. * Resolve a problem with python isinstance which considers 'False' is an integer and which makes OpenERP create operation_key field as integer instead of char. * Convert a return None to return False, because the XML-RPC protocol doesn't support returning None.
…or: global name 'pooler' is not defined" al iniciar el calculo.
… sólo uno y arrelgar un bug en la generación del modelo cuando el partner tiene el campo title lleno.
…y H que son respectivamente Entregas intracomunitarias con exención de tasas y Entregas intracomunitarias con exención de tasas por un representante fiscal oficial fueron publicadas el 26/11/2011 en el boe. Se puede ver el artículo en: http://planartus.blogspot.es/1309888740/
…ron marcados como no instalables mientras no se compruebe que funcionan o migren, para poder usarlos o probarlos se debería poner el atributo installable de los ficheros __openerp__.py de cada módulo a True
…n os import de objetos de OpenERP, el namespace openerp, refactorizado a PEP-8 y adaptacion vistas a formato 7
…n_es_aeat. * Traducciones. * Vista del wizard BOE * Vistas de facturas mejoradas * Icono * Asignar una clave a las facturas ya existentes.
…49 y l10n_es_payment_order
…turas rectificativas a declarar.
…e o2m [FIX] l10n_es_aeat_mod349: Añadida restricción que impide eliminar facturas que aparezcan en registros de detalle
* IMP: Fiscal position onchange in new API + speed imp + refactoring * FIX: l10n_es_aeat_mod349: Remove check of names There's no need of a check about the name validity, because l10n_es_aeat already transform all the exported strings to valid ASCII characters (though unidecode), so I remove it entirely this check. * FIX: Use first period year in export Relying in fiscal year code for getting the fiscal year is not safe, because you can use that code for defining your journal sequences (for example, with the module account_auto_fy_sequence). We can't use also the year of the fiscal year, because you can have split fiscal years (i. e. like the academic courses). What we uses then is the year of the first period of the declaration, as there's no legal possibility of having mixed periods from different years.
…er calcular el 349 en períodos distintos de los fiscales
There can be multiple cancelled reports that shouldn't be taken into account when looking for previous 349 reports.
Contributor
|
/ocabot migration l10n_es_aeat_mod349 |
sergioM-S73
force-pushed
the
19.0-mig-l10n_es_aeat_mod349
branch
from
March 20, 2026 12:04
54e22d1 to
4f84ae8
Compare
sergioM-S73
force-pushed
the
19.0-mig-l10n_es_aeat_mod349
branch
from
March 20, 2026 13:00
4f84ae8 to
cb36743
Compare
RabbitJon-S73
approved these changes
Mar 20, 2026
sergioM-S73
force-pushed
the
19.0-mig-l10n_es_aeat_mod349
branch
from
March 23, 2026 16:17
cb36743 to
ddf5afb
Compare
pedrobaeza
reviewed
Mar 25, 2026
|
|
||
| def _taxes_without_operation_key(self): | ||
| map_349_lines = self.env["aeat.349.map.line"].search([]) | ||
| map_349_lines = self.env["aeat.349.map.line"].search([], limit=50) |
Contributor
Author
There was a problem hiding this comment.
@pedrobaeza Se ha limitado porque aparece este error en el pre-commit:
Y el modelo "aeat.349.map.line" solo tiene 5 registros
Member
There was a problem hiding this comment.
Uhm, no te creas que me gusta mucho ese linter, pero creo que es conveniente silenciarlo en este caso, porque digamos que sabemos lo que nos hacemos. Es peor que por lo que sea, esto crezca y, ese límite de 50 se quede corto. Pon # pylint: disable=no-search-all.
También el comentario de mejorar rendimiento sigue siendo válido, porque no es por el limit por lo que no rinde.
Contributor
|
This PR has the |
sergioM-S73
force-pushed
the
19.0-mig-l10n_es_aeat_mod349
branch
from
March 26, 2026 07:58
ddf5afb to
4d22f48
Compare
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 9c168da. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.