[19.0][MIG] l10n_es_aeat_mod216: Migration to 19.0 - #4912
Merged
Conversation
EmilioPascual
force-pushed
the
19.0-mig-l10n_es_aeat_mod216
branch
2 times, most recently
from
March 20, 2026 15:37
1930247 to
24dc871
Compare
Contributor
|
/ocabot migration l10n_es_aeat_mod216 |
ArantxaSudon
approved these changes
Mar 24, 2026
ArantxaSudon
left a comment
ArantxaSudon
left a comment
Contributor
There was a problem hiding this comment.
Revisión funcional
Comprobado que recoge correctamente el mapeo de impuestos y que calcula los resultados teniendo en cuenta las casillas editables
Gracias @EmilioPascual
@moduon MT-14047
EmilioPascual
added a commit
to moduon/l10n-spain
that referenced
this pull request
Apr 6, 2026
Add temporary reference to PR OCA#4912 for l10n_es_aeat_mod216 dependency
…lculo por códigos de impuestos generalizado + tratamiento residentes 216 y cálculo, traducciones
…lugar de recordset + gestionar grupos de compañías
…ixes OCA#290 Cuando se tienen campos related, aunque el valor no se cambie, Odoo lanza una escritura en el objeto relacionado cada vez que se guarda el objeto principal. En el caso de la moneda asociada a la compañía, hace que aquellos usuarios que no tengan permiso para modificar la compañía (la mayoría), falle en la creación del modelo.
El anterior método utilizado, al tener una clase y un many2one genérico, no permitía poner los datos en múltiples modelos hijos, ya que se repetían los IDs, y cogía los datos de un modelo en otros. Con este nuevo sistema, se sigue utilizando una tabla, pero con doble índice: el modelo y el ID, parecido a un campo reference, pero gestionado por código propio en el método de cálculo. El 303 está adaptado a este nuevo sistema, y se incluye un script de migración que conserve los datos.
* Standard migration procedure
a nivel individualizado, sino agrupadas. Se corrije el filtro de asientos del mod 111 para que se tengan en cuenta los apuntes contables asociados a IRPF para tanto empresas que son residentes como para el caso en que no se ha informado la empresa en el apunte contable de la nómina. En caso del modelo 216, sí que parece más justificado tener que introducir el campo empresa.
This way, we don't initially see all the subconfigs for each model and we can concentrate on main export configurations. This is got through `active` field default behaviour. Archived config are still directly searchable through the subconfig selector in the configuration line. All models export configs have been adapted to this new approach.
Previous approach was not correct, as the used taxes don't apply to non resident. We use now l10n_es_irnr module for having proper taxes, map them in the model, and adapt the rest of the needed things.
* Float > Monetary and remove view definition * casilla_07 must be monetary (float), not integer
* Include chatter (mail.thread) * Include activities (mail.activity.mixin) * Track AEAT report state change * Include new admin user in AEAT group by default
…n tests This way, we can reuse it in other modules that don't inherit AEAT report like SII. We also clean a non needed reading of the tax description field. Tests were still using description method for populating data, so we switch to new system and perform needed changes in dependent tests. s
…agencia [IMP] l10n_es_aeat*: cambio de menu a declaraciones con submenus por agencia [IMP] l10n_es_aeat*: cambio de menu a declaraciones con submenus por agencia
Update model 216 following the new directions for 2024, https://sede.agenciatributaria.gob.es/Sede/todas-gestiones/impuestos-tasas/impuesto-sobre-renta-no-residentes/modelo-216-irnr______sos-cuenta-declaracion-ingreso_/instrucciones-modelo-216-presentacion-ejercicio-siguientes.html, and the new register designer for 2024 https://sede.agenciatributaria.gob.es/static_files/Sede/Disenyo_registro/DR_200_299/archivos_24/DR200-2024.xls MT-5789
Using the openupgradelib decorator, we have env, not cr.
Currently translated at 72.3% (97 of 134 strings) Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_aeat_mod216 Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_aeat_mod216/es/
- ASCII encoding is adding a final 'B' that is breaking the AEAT import. - pre-commit stripped out the space in the previous declaration, so let's use `eval` for restoring the space and not having this problem in the future.
The lines with type "Num" have not sign according to https://sede.agenciatributaria.gob.es/static_files/Sede/Disenyo_registro/DR_200_299/archivos_24/216e2024.xlsx MT-13343 @moduon
EmilioPascual
force-pushed
the
19.0-mig-l10n_es_aeat_mod216
branch
from
April 6, 2026 11:35
24dc871 to
ef11bd3
Compare
1 task
Contributor
|
This PR has the |
Contributor
|
This PR looks fantastic, let's merge it! |
Contributor
|
Congratulations, your PR was merged at caae9a1. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MT-14047 @moduon