[19.0][FIX] l10n_es_aeat: Switch the equivalent tax mechanism to other level - #5048
Merged
OCA-git-bot merged 1 commit intoJun 16, 2026
Merged
Conversation
Contributor
|
Hi @pedrobaeza, |
OCA-git-bot
added
series:19.0
mod:l10n_es_aeat_sii_oca
Member
|
Iba a hacer este fw-port cuando revisara y fusionar el VAT book, porque el PR abierto no contiene el parche. |
SII and other modules don't use the mapping mechanism of `l10n.es.aeat.map.tax.line`, so we need to put it at other level that is used for all. Thus, it has been required to refactor all the involved modules, now calling a new extra method at company level, that is able to return several taxes at once, taking into account the equivalent ones. Some refactor of such involved methods has been done taking the occasion to improve the code.
Contributor
Author
|
Ya, es que estaba migrando de nuevo el vat book a 19 ya que #4884 no parece avanzar y me he topado con que necesitaba este commit, asi que ya he hecho el fwp. Espero que no te importe |
EmilioPascual
force-pushed
the
19.0-fix-l10n_es_aeat-equivalent_tax
branch
from
June 16, 2026 08:41
4f566b6 to
92278c4
Compare
pedrobaeza
approved these changes
Jun 16, 2026
pedrobaeza
left a comment
pedrobaeza
left a comment
Member
There was a problem hiding this comment.
De acuerdo entonces.
/ocabot merge minor
Contributor
|
On my way to merge this fine PR! |
Contributor
|
Congratulations, your PR was merged at 7b87d16. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-port of #5043 and #5037, which redoes #5031, which was a refinement of #5018.
Changes to non-migrated modules have been removed.
SII and other modules don't use the mapping mechanism of
l10n.es.aeat.map.tax.line, so we need to put it at other level that is used for all.Thus, it has been required to refactor all the involved modules, now calling a new extra method at company level, that is able to return several taxes at once, taking into account the equivalent ones.
Some refactor of such involved methods has been done taking the occasion to improve the code.
@moduon