[19.0][MIG] l10n_es_vat_book - #5049
Merged
Merged
Conversation
facturas "normales" como rectificativas.
* Translations * Terms homogeneization * README by fragments * Test reports
When a large amount of move lines are processed (hundreds of thousands) it can lead to a MemoryError when we try to calculate the VAT book
Steps to reproduce the problem: - Create an invoice with 0 amount, but any line. - Put in that line a tax "Recargo equivalencia X%". - Create a VAT book in the interval of the invoice. - Compute the book - We get the error File "/home/odoo/build/OCA/l10n-spain/l10n_es_vat_book/models/l10n_es_vat_book.py", line 265, in upsert_book_line_tax lambda l: not l['special_tax_group'], implied_lines)) StopIteration This is due to a reused dictionary in the loop, so we perform a copy of the original dictionary each time. Fixes OCA#1221
… wkhtmltopdf pueda imprimirlos correctamente
…with subsequent taxes base checked
It was not possible until the merge of odoo/odoo#55491
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_vat_book Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_vat_book/
…it is a harmless tax and does not need to be reflected.
Currently translated at 98.2% (164 of 167 strings) Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_vat_book Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_vat_book/es/
Currently translated at 99.4% (166 of 167 strings) Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_vat_book Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_vat_book/es/
Currently translated at 100.0% (167 of 167 strings) Translation: l10n-spain-18.0/l10n-spain-18.0-l10n_es_vat_book Translate-URL: https://translation.odoo-community.org/projects/l10n-spain-18-0/l10n-spain-18-0-l10n_es_vat_book/ca/
SII and other modules don't use the mapping mechanism of `l10n.es.aeat.map.tax.line`, so we need to put it at other level that is used for all. Thus, it has been required to refactor all the involved modules, now calling a new extra method at company level, that is able to return several taxes at once, taking into account the equivalent ones. Some refactor of such involved methods has been done taking the occasion to improve the code.
Contributor
|
Gracias Emilio /ocabot migration l10n_es_vat_book |
Member
|
De momento no incluyas 6ab6a6b |
EmilioPascual
force-pushed
the
19.0-mig-l10n_es_vat_book
branch
from
June 22, 2026 05:30
6ab6a6b to
24c21f5
Compare
Contributor
Author
Quitado |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
Congratulations, your PR was merged at af07502. Thanks a lot for contributing to OCA. ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersed: #4884 (No había respuestas en el PR y pre-commit y tests estaban en rojo)
¿@Shide @ArantxaSudon @pedrobaeza @HaraldPanten podéis revisar, por favor? Gracias
MT-12852 @moduon